added missing calls

Author: sanderegg

services/autoscaling/src/simcore_service_autoscaling/modules/cluster_scaling/_provider_dynamic.py

@@ -1,4 +1,5 @@
 from aws_library.ec2 import EC2InstanceData, EC2Tags, Resources
+from aws_library.ec2._models import EC2InstanceType
 from fastapi import FastAPI
 from models_library.docker import DockerLabelKey
 from models_library.generated_models.docker_rest_api import Node, Task
@@ -104,3 +105,19 @@ async def try_retire_nodes(self, app: FastAPI) -> None:
         assert self  # nosec
         assert app  # nosec
         # nothing to do here
+
+    def add_instance_generic_resources(
+        self, app: FastAPI, instance: EC2InstanceData
+    ) -> None:
+        assert self  # nosec
+        assert app  # nosec
+        assert instance  # nosec
+        # nothing to do at the moment
+
+    def add_instance_type_generic_resource(
+        self, app: FastAPI, instance_type: EC2InstanceType
+    ) -> None:
+        assert self  # nosec
+        assert app  # nosec
+        assert instance_type  # nosec
+        # nothing to do at the moment

services/autoscaling/src/simcore_service_autoscaling/utils/cluster_scaling.py

@@ -109,7 +109,7 @@ def find_selected_instance_type_for_task(
     selected_instance = filtered_instances[0]
 
     # check that the assigned resources and the machine resource fit
-    if task_required_resources > selected_instance.resources:
+    if not (task_required_resources <= selected_instance.resources):
         raise TaskRequirementsAboveRequiredEC2InstanceTypeError(
             task=task,
             instance_type=selected_instance,