ensure we do not re-connect when done

Author: sanderegg

packages/pytest-simcore/src/pytest_simcore/helpers/playwright.py

@@ -218,13 +218,10 @@ def expect_event(
         predicate: typing.Callable | None = None,
         *,
         timeout: float | None = None,
-        expecting_closing: bool = False,
     ) -> EventContextManager:
         """
         Register an event listener with support for reconnection.
         """
-        if expecting_closing:
-            self.auto_reconnect = False
         output = self.ws.expect_event(event, predicate, timeout=timeout)
         self._registered_events.append((event, predicate))
         return output

tests/e2e-playwright/tests/conftest.py

@@ -598,7 +598,6 @@ def wait_for_done(response):
                     "framereceived",
                     SocketIOProjectClosedWaiter(ctx.logger),
                     timeout=_PROJECT_CLOSING_TIMEOUT,
-                    expecting_closing=True,
                 )
             )
         if created_project_uuids:

tests/e2e-playwright/tests/jupyterlabs/test_jupyterlab.py

@@ -164,6 +164,8 @@ def test_jupyterlab(
                 )
                 terminal.press("Enter")
 
+            restartable_terminal_web_socket.auto_reconnect = False
+
         # NOTE: this is to let some tester see something
         page.wait_for_timeout(2000)
 

tests/e2e-playwright/tests/tip/test_ti_plan.py

@@ -344,3 +344,5 @@ def test_classic_ti_plan(  # noqa: PLR0915
                 s4l_postpro_iframe.get_by_test_id("tree-item-SurfaceViewer").nth(
                     0
                 ).click()
+
+    restartable_jlab_websocket.auto_reconnect = False