pylint and not required

Author: pcrespov

packages/service-library/src/servicelib/logging_errors.py

@@ -1,6 +1,6 @@
 import logging
 from pprint import pformat
-from typing import Any, NotRequired, TypedDict
+from typing import Any, TypedDict
 
 from models_library.error_codes import ErrorCodeStr
 from models_library.errors_classes import OsparcErrorMixin
@@ -43,7 +43,7 @@ def create_troubleshotting_log_message(
 
 class LogKwargs(TypedDict):
     msg: str
-    extra: NotRequired[LogExtra | None]
+    extra: LogExtra
 
 
 def create_troubleshotting_log_kwargs(

packages/service-library/src/servicelib/logging_utils.py

@@ -14,8 +14,7 @@
 from datetime import datetime
 from inspect import getframeinfo, stack
 from pathlib import Path
-from pprint import pformat
-from typing import Any, TypeAlias, TypedDict, TypeVar
+from typing import Any, NotRequired, TypeAlias, TypedDict, TypeVar
 
 from .utils_secrets import mask_sensitive_data
 
@@ -319,9 +318,9 @@ def log_catch(logger: logging.Logger, *, reraise: bool = True) -> Iterator[None]
             raise exc from exc
 
 
-class LogExtra(TypedDict, total=False):
-    log_uid: str
-    log_oec: str
+class LogExtra(TypedDict):
+    log_uid: NotRequired[str]
+    log_oec: NotRequired[str]
 
 
 LogLevelInt: TypeAlias = int

packages/service-library/tests/test_logging_errors.py

@@ -41,8 +41,11 @@ class MyError(OsparcErrorMixin, RuntimeError):
     )
 
     assert log_kwargs["msg"] == log_msg
+    assert log_kwargs["extra"] is not None
     assert (
-        log_kwargs["extra"]["log_uid"] == "123"
+        # pylint: disable=unsubscriptable-object
+        log_kwargs["extra"]["log_uid"]
+        == "123"
     ), "user_id is injected as extra from context"
 
     with caplog.at_level(logging.WARNING):