update

Author: giancarloromeo

services/storage/src/simcore_service_storage/modules/celery/_common.py

@@ -40,6 +40,12 @@ def wrapper(task: Task, *args, **kwargs):
             exc_message = f"{exc}"
             exc_traceback = traceback.format_exc().split('\n')
 
+            _logger.exception(
+                "Task %s failed with exception: %s",
+                task.request.id,
+                exc_message,
+            )
+
             task.update_state(
                 state="ERROR",
                 meta=TaskError(

services/storage/src/simcore_service_storage/modules/celery/client.py

@@ -34,6 +34,9 @@
 _CELERY_TASK_ID_KEY_SEPARATOR: Final[str] = ":"
 _CELERY_TASK_ID_KEY_ENCODING = "utf-8"
 
+_MIN_PROGRESS_VALUE = 0.0
+_MAX_PROGRESS_VALUE = 100.0
+
 
 def _build_context_prefix(task_context: TaskContext) -> list[str]:
     return [f"{task_context[key]}" for key in sorted(task_context)]
@@ -97,8 +100,8 @@ def _get_progress_report(
             TaskState.ERROR,
             TaskState.SUCCESS,
         ):
-            return ProgressReport(actual_value=100.0)
-        return ProgressReport(actual_value=0.0)
+            return ProgressReport(actual_value=_MAX_PROGRESS_VALUE)
+        return ProgressReport(actual_value=_MIN_PROGRESS_VALUE)
 
     def _get_state(self, task_context: TaskContext, task_uuid: TaskUUID) -> TaskState:
         task_id = _build_task_id(task_context, task_uuid)

services/storage/tests/unit/modules/celery/test_celery.py

@@ -96,15 +96,15 @@ async def test_sumitting_task_calling_async_function_results_with_success_state(
         stop=stop_after_delay(30),
     ):
         with attempt:
-            progress = await celery_client.get_task_status(task_context, task_uuid)
-            assert progress.task_state == TaskState.SUCCESS
+            status = await celery_client.get_task_status(task_context, task_uuid)
+            assert status.task_state == TaskState.SUCCESS
 
-    assert (
-        await celery_client.get_task_result(task_context, task_uuid)
-    ) == "archive.zip"
     assert (
         await celery_client.get_task_status(task_context, task_uuid)
     ).task_state == TaskState.SUCCESS
+    assert (
+        await celery_client.get_task_result(task_context, task_uuid)
+    ) == "archive.zip"
 
 
 @pytest.mark.usefixtures("celery_worker")