Skip to content

Commit 0eefce2

Browse files
committed
less page context
1 parent 9047535 commit 0eefce2

File tree

2 files changed

+4
-20
lines changed

2 files changed

+4
-20
lines changed

services/static-webserver/client/source/class/osparc/desktop/SlideshowView.js

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -130,12 +130,6 @@ qx.Class.define("osparc.desktop.SlideshowView", {
130130
apply: "__applyMaximized",
131131
event: "changeMaximized"
132132
},
133-
134-
pageContext: {
135-
check: ["guided", "app"],
136-
nullable: false,
137-
init: "guided"
138-
}
139133
},
140134

141135
statics: {
@@ -269,9 +263,6 @@ qx.Class.define("osparc.desktop.SlideshowView", {
269263
view = new osparc.node.slideshow.NodeView();
270264
}
271265
view.setNode(node);
272-
if (node.isDynamic()) {
273-
view.getSettingsLayout().setVisibility(["app", "standalone"].includes(this.getPageContext()) ? "excluded" : "visible");
274-
}
275266
}
276267
this.__connectMaximizeEvents(node);
277268
this.__styleView(node, view);
@@ -376,7 +367,6 @@ qx.Class.define("osparc.desktop.SlideshowView", {
376367
});
377368
}
378369
}
379-
this.setPageContext("app");
380370
this.__slideshowToolbar.populateButtons(true);
381371
const currentNodeId = this.getStudy().getUi().getCurrentNodeId();
382372
const isValid = slideshow.getPosition(currentNodeId) !== -1;

services/static-webserver/client/source/class/osparc/file/FilePicker.js

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -39,28 +39,22 @@ qx.Class.define("osparc.file.FilePicker", {
3939
/**
4040
* @param node {osparc.data.model.Node} Node owning the widget
4141
*/
42-
construct: function(node, pageContext = "workbench") {
42+
construct: function(node, viewContext = "workbench") {
4343
this.base(arguments);
4444

4545
this._setLayout(new qx.ui.layout.VBox(20));
4646

4747
this.set({
4848
node,
49-
pageContext
5049
});
5150

52-
this.__buildLayout();
51+
this.__buildLayout(viewContext);
5352
},
5453

5554
properties: {
5655
node: {
5756
check: "osparc.data.model.Node"
5857
},
59-
60-
pageContext: {
61-
check: ["workbench", "guided", "app", "standalone"],
62-
nullable: false
63-
}
6458
},
6559

6660
events: {
@@ -284,14 +278,14 @@ qx.Class.define("osparc.file.FilePicker", {
284278
}
285279
},
286280

287-
__buildLayout: function() {
281+
__buildLayout: function(viewContext) {
288282
this._removeAll();
289283
const hasOutput = osparc.file.FilePicker.hasOutputAssigned(this.getNode().getOutputs());
290284
if (hasOutput) {
291285
this.__buildInfoLayout();
292286
} else {
293287
this.__addProgressBar();
294-
if (this.getPageContext() === "workbench") {
288+
if (viewContext === "workbench") {
295289
this.__buildWorkbenchLayout();
296290
} else {
297291
this.setMargin(10);

0 commit comments

Comments
 (0)