@sanderegg move LOG_FILE_NAME to constants

Author: bisgaard-itis

services/director-v2/src/simcore_service_director_v2/api/rpc/_computations_tasks.py

@@ -9,10 +9,10 @@
 )
 from simcore_sdk.node_ports_common import data_items_utils
 
+from ...constants import LOGS_FILE_NAME
 from ...core.errors import PipelineNotFoundError
 from ...modules.db.repositories.comp_pipelines import CompPipelinesRepository
 from ...modules.db.repositories.comp_tasks import CompTasksRepository
-from ...utils import dask as dask_utils
 from ...utils.computations_tasks import get_pipeline_info
 
 router = RPCRouter()
@@ -41,7 +41,7 @@ async def get_computation_task_log_file_ids(
         TaskLogFileIdGet(
             task_id=node_id,
             file_id=data_items_utils.create_simcore_file_id(
-                Path(dask_utils.LOGS_FILE_NAME), f"{project_id}", f"{node_id}"
+                Path(LOGS_FILE_NAME), f"{project_id}", f"{node_id}"
             ),
         )
         for node_id in iter_task_ids

services/director-v2/src/simcore_service_director_v2/constants.py

@@ -15,13 +15,17 @@
 # - local
 # - itisfoundation
 # - 10.0.0.0:8473 (IP & Port)
-DYNAMIC_SIDECAR_DOCKER_IMAGE_RE = (
+DYNAMIC_SIDECAR_DOCKER_IMAGE_RE: Final[str] = (
     r"^(([_a-zA-Z0-9:.-]+)/)?(dynamic-sidecar):([_a-zA-Z0-9.-]+)$"
 )
 
-REGEX_DY_SERVICE_SIDECAR = rf"^{DYNAMIC_SIDECAR_SERVICE_PREFIX}_[a-zA-Z0-9-_]*"
-REGEX_DY_SERVICE_PROXY = rf"^{DYNAMIC_PROXY_SERVICE_PREFIX}_[a-zA-Z0-9-_]*"
+LOGS_FILE_NAME: Final[str] = "logs.zip"
 
-UNDEFINED_STR_METADATA = "undefined-metadata"
-UNDEFINED_DOCKER_LABEL = "undefined-label"
-UNDEFINED_API_BASE_URL = "https://api.local"
+REGEX_DY_SERVICE_SIDECAR: Final[str] = (
+    rf"^{DYNAMIC_SIDECAR_SERVICE_PREFIX}_[a-zA-Z0-9-_]*"
+)
+REGEX_DY_SERVICE_PROXY: Final[str] = rf"^{DYNAMIC_PROXY_SERVICE_PREFIX}_[a-zA-Z0-9-_]*"
+
+UNDEFINED_STR_METADATA: Final[str] = "undefined-metadata"
+UNDEFINED_DOCKER_LABEL: Final[str] = "undefined-label"
+UNDEFINED_API_BASE_URL: Final[str] = "https://api.local"

services/director-v2/src/simcore_service_director_v2/utils/dask.py

@@ -40,7 +40,7 @@
 from simcore_sdk.node_ports_v2.links import ItemValue as _NPItemValue
 from sqlalchemy.ext.asyncio import AsyncEngine
 
-from ..constants import UNDEFINED_API_BASE_URL, UNDEFINED_DOCKER_LABEL
+from ..constants import LOGS_FILE_NAME, UNDEFINED_API_BASE_URL, UNDEFINED_DOCKER_LABEL
 from ..core.errors import (
     ComputationalBackendNotConnectedError,
     ComputationalSchedulerChangedError,
@@ -261,9 +261,6 @@ async def compute_output_data_schema(
     return TaskOutputDataSchema.model_validate(output_data_schema)
 
 
-LOGS_FILE_NAME = "logs.zip"
-
-
 async def compute_service_log_file_upload_link(
     user_id: UserID,
     project_id: ProjectID,