Skip to content

Commit 0f25bde

Browse files
committed
fixed setup of db
1 parent 8895bed commit 0f25bde

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

packages/service-library/src/servicelib/db_async_engine.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
get_pg_engine_stateinfo,
88
raise_if_migration_not_ready,
99
)
10-
from sqlalchemy.ext.asyncio import AsyncEngine, create_async_engine
10+
from sqlalchemy.ext.asyncio import create_async_engine
1111
from tenacity import retry
1212

1313
from .logging_utils import log_context
@@ -27,12 +27,16 @@ async def connect_to_db(app: FastAPI, settings: PostgresSettings) -> None:
2727
with log_context(
2828
_logger, logging.DEBUG, f"connection to db {settings.dsn_with_async_sqlalchemy}"
2929
):
30-
engine: AsyncEngine = create_async_engine(
30+
engine = create_async_engine(
3131
settings.dsn_with_async_sqlalchemy,
3232
pool_size=settings.POSTGRES_MINSIZE,
3333
max_overflow=settings.POSTGRES_MAXSIZE - settings.POSTGRES_MINSIZE,
3434
connect_args={
35-
"server_settings": {"application_name": settings.POSTGRES_CLIENT_NAME}
35+
"server_settings": (
36+
{"application_name": settings.POSTGRES_CLIENT_NAME}
37+
if settings.POSTGRES_CLIENT_NAME
38+
else None
39+
)
3640
},
3741
pool_pre_ping=True, # https://docs.sqlalchemy.org/en/14/core/pooling.html#dealing-with-disconnects
3842
future=True, # this uses sqlalchemy 2.0 API, shall be removed when sqlalchemy 2.0 is released

packages/service-library/src/servicelib/db_asyncpg_utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ async def create_async_engine_and_database_ready(
3737
settings.dsn_with_async_sqlalchemy,
3838
pool_size=settings.POSTGRES_MINSIZE,
3939
max_overflow=settings.POSTGRES_MAXSIZE - settings.POSTGRES_MINSIZE,
40-
connect_args={"server_settings": server_settings},
40+
connect_args={"server_settings": server_settings} if server_settings else None,
4141
pool_pre_ping=True, # https://docs.sqlalchemy.org/en/14/core/pooling.html#dealing-with-disconnects
4242
future=True, # this uses sqlalchemy 2.0 API, shall be removed when sqlalchemy 2.0 is released
4343
)

0 commit comments

Comments
 (0)