feedback

Author: Andrei Neagu

services/notifications/setup.py

@@ -24,7 +24,7 @@ def read_reqs(reqs_path: Path) -> set[str]:
 NAME = "simcore-service-notifications"
 VERSION = (CURRENT_DIR / "VERSION").read_text().strip()
 AUTHORS = ("Andrei Neagu (GitHK)",)
-DESCRIPTION = "Service for executing commands on docker nodes"
+DESCRIPTION = "Service used for sending notifications to users via different channels"
 
 PROD_REQUIREMENTS = tuple(
     read_reqs(CURRENT_DIR / "requirements" / "_base.txt")

services/notifications/src/simcore_service_notifications/api/rpc/routing.py

@@ -8,7 +8,7 @@
 from ...clients.rabbitmq import get_rabbitmq_rpc_server
 
 ROUTERS: list[RPCRouter] = [
-    # import form various domains and attach here
+    # import and use all routers here
 ]
 
 

services/notifications/src/simcore_service_notifications/clients/postgres/_liveness.py

@@ -1,6 +1,7 @@
 import logging
 from asyncio import Task
 from datetime import timedelta
+from typing import Final
 
 from fastapi import FastAPI
 from models_library.healthchecks import IsResponsive, LivenessResult
@@ -12,6 +13,8 @@
 
 _logger = logging.getLogger(__name__)
 
+_LVENESS_CHECK_INTERVAL: Final[timedelta] = timedelta(seconds=10)
+
 
 class PostgresLiveness:
     def __init__(self, app: FastAPI) -> None:
@@ -30,7 +33,7 @@ def is_responsive(self) -> bool:
     async def setup(self) -> None:
         self._task = create_periodic_task(
             self._check_task,
-            interval=timedelta(seconds=10),
+            interval=_LVENESS_CHECK_INTERVAL,
             task_name="posgress_liveness_check",
         )