review @pcrespov

Author: matusdrobuliak66

packages/service-library/src/servicelib/project_lock.py

@@ -11,8 +11,9 @@
 from models_library.projects_access import Owner
 from models_library.projects_state import ProjectLocked, ProjectStatus
 from redis.asyncio.lock import Lock
-from servicelib.background_task import periodic_task
-from servicelib.logging_utils import log_context
+
+from .background_task import periodic_task
+from .logging_utils import log_context
 
 _logger = logging.getLogger(__name__)
 

services/efs-guardian/src/simcore_service_efs_guardian/services/efs_manager.py

@@ -110,12 +110,12 @@ async def list_projects_across_whole_efs(self) -> list[ProjectID]:
                     _project_id = parse_obj_as(ProjectID, item)
                     directories.append(_project_id)
                 except ValueError:
-                    _logger.warning(
+                    _logger.error(
                         "This is not a project ID. This should not happen! %s",
                         _item_path,
                     )
             else:
-                _logger.warning(
+                _logger.error(
                     "This is not a directory. This should not happen! %s",
                     _item_path,
                 )
@@ -131,7 +131,16 @@ async def remove_project_efs_data(self, project_id: ProjectID) -> None:
 
         if Path.exists(_dir_path):
             # Remove the directory and all its contents
-            shutil.rmtree(_dir_path)
-            _logger.info("%s has been deleted.", _dir_path)
+            try:
+                shutil.rmtree(_dir_path)
+                _logger.info("%s has been deleted.", _dir_path)
+            except FileNotFoundError as e:
+                _logger.error("Directory %s does not exist.", _dir_path)
+            except PermissionError as e:
+                _logger.error("Permission denied when trying to delete %s.", _dir_path)
+            except NotADirectoryError as e:
+                _logger.error("%s is not a directory.", _dir_path)
+            except OSError as e:
+                _logger.error("Error: %s. Issue with path: %s", e, _dir_path)
         else:
-            _logger.warning("%s does not exist.", _dir_path)
+            _logger.error("%s does not exist.", _dir_path)