🏗️ Rename test for service upgrade metadata inheritance and add assertions for user group and product exposure

Author: pcrespov

services/catalog/src/simcore_service_catalog/service/access_rights.py

@@ -153,6 +153,8 @@ async def _find_previous_compatible_release(
     for release in latest_releases:
         # COMPATIBILITY RULE:
         # - a patch release is compatible with the previous patch release
+
+        # FIXME: not all compatible releases!!!
         if is_patch_release(new_version, release.version):
             return release
 

services/catalog/tests/unit/with_dbs/test_service_access_rights.py

@@ -86,7 +86,7 @@ def test_reduce_access_rights():
     }
 
 
-async def test_auto_upgrade_policy(
+async def test_service_upgrade_metadata_inheritance(
     sqlalchemy_async_engine: AsyncEngine,
     user: dict[str, Any],
     user_groups_ids: list[GroupID],
@@ -98,6 +98,8 @@ async def test_auto_upgrade_policy(
 ):
     everyone_gid, user_gid, team_gid = user_groups_ids
 
+    assert user_gid == user["primary_gid"]
+
     # Avoids calls to director API
     mocker.patch.object(
         simcore_service_catalog.service.access_rights,
@@ -223,8 +225,11 @@ async def test_auto_upgrade_policy(
     service_access_rights = reduce_access_rights(service_access_rights)
 
     assert len(service_access_rights) == 4
-    assert {a.gid for a in service_access_rights} == {team_gid, owner_gid}
+    assert {a.gid for a in service_access_rights} == {
+        team_gid,
+        owner_gid,
+    }, "last version was exposed to a team"
     assert {a.product_name for a in service_access_rights} == {
         target_product,
         other_product,
-    }
+    }, "last version was exposed to two products"