add yet another test

Author: matusdrobuliak66

packages/simcore-sdk/src/simcore_sdk/node_ports_common/dbmanager.py

@@ -51,6 +51,35 @@ async def _get_node_from_db(
     return node
 
 
+async def _update_comp_run_snapshot_tasks_if_computational(
+    engine: AsyncEngine,
+    connection: AsyncConnection,
+    project_id: str,
+    node_uuid: str,
+    node_configuration: dict,
+) -> None:
+    """
+    Updates comp_run_snapshot_tasks table for computational nodes.
+    """
+    node = await _get_node_from_db(project_id, node_uuid, connection)
+    if node.node_class == NodeClass.COMPUTATIONAL.value:
+        _latest_run_id = await get_latest_run_id_for_project(
+            engine, connection, project_id=project_id
+        )
+        await update_for_run_id_and_node_id(
+            engine,
+            connection,
+            run_id=_latest_run_id,
+            node_id=node_uuid,
+            data={
+                "schema": node_configuration["schema"],
+                "inputs": node_configuration["inputs"],
+                "outputs": node_configuration["outputs"],
+                "run_hash": node_configuration.get("run_hash"),
+            },
+        )
+
+
 class DBContextManager:
     def __init__(self, db_engine: AsyncEngine | None = None) -> None:
         self._db_engine: AsyncEngine | None = db_engine
@@ -113,26 +142,9 @@ async def write_ports_configuration(
             )
 
             # 2. Update comp_run_snapshot_tasks table only if the node is computational
-            node = await _get_node_from_db(project_id, node_uuid, connection)
-            if node.node_class == NodeClass.COMPUTATIONAL.value:
-                # 2.1 Get latest run id for the project
-                _latest_run_id = await get_latest_run_id_for_project(
-                    engine, connection, project_id=project_id
-                )
-
-                # 2.2 Update comp_run_snapshot_tasks table
-                await update_for_run_id_and_node_id(
-                    engine,
-                    connection,
-                    run_id=_latest_run_id,
-                    node_id=node_uuid,
-                    data={
-                        "schema": node_configuration["schema"],
-                        "inputs": node_configuration["inputs"],
-                        "outputs": node_configuration["outputs"],
-                        "run_hash": node_configuration.get("run_hash"),
-                    },
-                )
+            await _update_comp_run_snapshot_tasks_if_computational(
+                engine, connection, project_id, node_uuid, node_configuration
+            )
 
     async def get_ports_configuration_from_node_uuid(
         self, project_id: str, node_uuid: str

packages/simcore-sdk/tests/unit/test_node_ports_common_dbmanager_helpers.py

@@ -0,0 +1,73 @@
+import types
+from unittest.mock import AsyncMock
+
+from simcore_sdk.node_ports_common import dbmanager
+
+
+async def test_update_comp_run_snapshot_tasks_if_computational(monkeypatch):
+    engine = AsyncMock()
+    connection = AsyncMock()
+    project_id = "project-1"
+    node_uuid = "node-1"
+    node_configuration = {
+        "schema": {"foo": "bar"},
+        "inputs": {"a": 1},
+        "outputs": {"b": 2},
+        "run_hash": "hash123",
+    }
+    node = types.SimpleNamespace(node_class="COMPUTATIONAL")
+
+    get_node_mock = AsyncMock(return_value=node)
+    get_latest_run_id_mock = AsyncMock(return_value="run-1")
+    update_mock = AsyncMock()
+
+    monkeypatch.setattr(dbmanager, "_get_node_from_db", get_node_mock)
+    monkeypatch.setattr(
+        dbmanager, "get_latest_run_id_for_project", get_latest_run_id_mock
+    )
+    monkeypatch.setattr(dbmanager, "update_for_run_id_and_node_id", update_mock)
+
+    await dbmanager._update_comp_run_snapshot_tasks_if_computational(
+        engine, connection, project_id, node_uuid, node_configuration
+    )
+
+    get_node_mock.assert_awaited_once_with(project_id, node_uuid, connection)
+    get_latest_run_id_mock.assert_awaited_once_with(
+        engine, connection, project_id=project_id
+    )
+    update_mock.assert_awaited_once()
+    _, kwargs = update_mock.call_args
+    assert kwargs["run_id"] == "run-1"
+    assert kwargs["node_id"] == node_uuid
+    assert kwargs["data"]["schema"] == node_configuration["schema"]
+
+
+async def test_update_comp_run_snapshot_tasks_if_not_computational(monkeypatch):
+    engine = AsyncMock()
+    connection = AsyncMock()
+    project_id = "project-2"
+    node_uuid = "node-2"
+    node_configuration = {
+        "schema": {},
+        "inputs": {},
+        "outputs": {},
+    }
+    node = types.SimpleNamespace(node_class="ITERATIVE")
+
+    get_node_mock = AsyncMock(return_value=node)
+    get_latest_run_id_mock = AsyncMock()
+    update_mock = AsyncMock()
+
+    monkeypatch.setattr(dbmanager, "_get_node_from_db", get_node_mock)
+    monkeypatch.setattr(
+        dbmanager, "get_latest_run_id_for_project", get_latest_run_id_mock
+    )
+    monkeypatch.setattr(dbmanager, "update_for_run_id_and_node_id", update_mock)
+
+    await dbmanager._update_comp_run_snapshot_tasks_if_computational(
+        engine, connection, project_id, node_uuid, node_configuration
+    )
+
+    get_node_mock.assert_awaited_once_with(project_id, node_uuid, connection)
+    get_latest_run_id_mock.assert_not_awaited()
+    update_mock.assert_not_awaited()