refactor interface

Author: Andrei Neagu

api/specs/web-server/_auth.py

@@ -19,7 +19,6 @@
 from simcore_service_webserver._meta import API_VTAG
 from simcore_service_webserver.login._2fa_handlers import Resend2faBody
 from simcore_service_webserver.login._auth_handlers import (
-    CheckAuthBody,
     LoginBody,
     LoginNextPage,
     LoginTwoFactorAuthBody,
@@ -158,8 +157,8 @@ async def logout(_body: LogoutBody):
 
 @router.get(
     "/auth:check",
-    response_model=Envelope[CheckAuthBody],
     operation_id="check_authentication",
+    status_code=status.HTTP_204_NO_CONTENT,
     responses={
         status.HTTP_401_UNAUTHORIZED: {
             "model": Envelope[Error],
@@ -168,7 +167,7 @@ async def logout(_body: LogoutBody):
     },
 )
 async def check_auth():
-    """checks if user is autheticated in the platform"""
+    """checks if user is authenticated in the platform"""
 
 
 @router.post(

services/web/server/src/simcore_service_webserver/api/v0/openapi.yaml

@@ -238,15 +238,11 @@ paths:
       tags:
       - auth
       summary: Check Auth
-      description: checks if user is autheticated in the platform
+      description: checks if user is authenticated in the platform
       operationId: check_authentication
       responses:
-        '200':
+        '204':
           description: Successful Response
-          content:
-            application/json:
-              schema:
-                $ref: '#/components/schemas/Envelope_CheckAuthBody_'
         '401':
           description: unauthorized reset due to invalid token code
           content:
@@ -4335,7 +4331,7 @@ paths:
         '403':
           description: ProjectInvalidRightsError
         '404':
-          description: UserDefaultWalletNotFoundError, ProjectNotFoundError
+          description: ProjectNotFoundError, UserDefaultWalletNotFoundError
         '409':
           description: ProjectTooManyProjectOpenedError
         '422':
@@ -6487,10 +6483,6 @@ components:
           format: password
           writeOnly: true
       additionalProperties: false
-    CheckAuthBody:
-      title: CheckAuthBody
-      type: object
-      properties: {}
     CheckpointAnnotations:
       title: CheckpointAnnotations
       type: object
@@ -7140,14 +7132,6 @@ components:
           $ref: '#/components/schemas/CatalogServiceGet'
         error:
           title: Error
-    Envelope_CheckAuthBody_:
-      title: Envelope[CheckAuthBody]
-      type: object
-      properties:
-        data:
-          $ref: '#/components/schemas/CheckAuthBody'
-        error:
-          title: Error
     Envelope_CheckpointApiModel_:
       title: Envelope[CheckpointApiModel]
       type: object

services/web/server/src/simcore_service_webserver/login/_auth_handlers.py

@@ -77,10 +77,6 @@ class LoginNextPage(NextPage[CodePageParams]):
     ...
 
 
-class CheckAuthBody(BaseModel):
-    ...
-
-
 @routes.post(f"/{API_VTAG}/auth/login", name="auth_login")
 @on_success_grant_session_access_to(
     name="auth_register_phone",
@@ -313,9 +309,10 @@ async def check_auth(request: web.Request) -> web.Response:
     # used primarily by Traefik auth middleware to verify session cookies
 
     # NOTE: for future development
-    # if databse access is added here, services like jupyter-math
+    # if database access is added here, services like jupyter-math
     # which load a lot of resources will have a big performance hit
-    # consider caching some properties required by this endpoit or rely on Redis
+    # consider caching some properties required by this endpoint or rely on Redis
+
+    assert request  # nosec
 
-    _ = request
-    return envelope_response(CheckAuthBody())
+    return web.json_response(status=status.HTTP_204_NO_CONTENT)