Skip to content

Commit 1343987

Browse files
committed
ensure test run if tools are not installed
1 parent 6647cd8 commit 1343987

File tree

2 files changed

+17
-15
lines changed

2 files changed

+17
-15
lines changed

packages/simcore-sdk/tests/integration/conftest.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,7 @@ def _assign_config(
337337
@pytest.fixture
338338
async def r_clone_settings_factory(
339339
minio_s3_settings: S3Settings, storage_service: URL
340-
) -> Awaitable[RCloneSettings]:
340+
) -> Callable[[], Awaitable[RCloneSettings]]:
341341
async def _factory() -> RCloneSettings:
342342
settings = RCloneSettings(
343343
R_CLONE_S3=minio_s3_settings, R_CLONE_PROVIDER=S3Provider.MINIO
@@ -347,35 +347,35 @@ async def _factory() -> RCloneSettings:
347347

348348
return settings
349349

350-
return _factory()
350+
return _factory
351351

352352

353353
@pytest.fixture
354354
async def aws_s3_cli_settings_factory(
355355
minio_s3_settings: S3Settings, storage_service: URL
356-
) -> Awaitable[AwsS3CliSettings]:
356+
) -> Callable[[], Awaitable[AwsS3CliSettings]]:
357357
async def _factory() -> AwsS3CliSettings:
358358
settings = AwsS3CliSettings(AWS_S3_CLI_S3=minio_s3_settings)
359359
if not await is_aws_s3_cli_available(settings):
360360
pytest.skip("aws cli not installed")
361361

362362
return settings
363363

364-
return _factory()
364+
return _factory
365365

366366

367367
@pytest.fixture
368368
async def r_clone_settings(
369-
r_clone_settings_factory: Awaitable[RCloneSettings],
369+
r_clone_settings_factory: Callable[[], Awaitable[RCloneSettings]],
370370
) -> RCloneSettings:
371-
return await r_clone_settings_factory
371+
return await r_clone_settings_factory()
372372

373373

374374
@pytest.fixture
375375
async def aws_s3_cli_settings(
376-
aws_s3_cli_settings_factory: Awaitable[AwsS3CliSettings],
376+
aws_s3_cli_settings_factory: Callable[[], Awaitable[AwsS3CliSettings]],
377377
) -> AwsS3CliSettings:
378-
return await aws_s3_cli_settings_factory
378+
return await aws_s3_cli_settings_factory()
379379

380380

381381
@pytest.fixture

packages/simcore-sdk/tests/integration/test_node_ports_common_filemanager.py

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -56,15 +56,17 @@ class _SyncSettings(BaseModel):
5656
"Both RClone and AwsS3Cli disabled",
5757
],
5858
)
59-
def optional_sync_settings(
60-
r_clone_settings: RCloneSettings,
61-
aws_s3_cli_settings: AwsS3CliSettings,
59+
async def optional_sync_settings(
60+
r_clone_settings_factory: Callable[[], Awaitable[RCloneSettings]],
61+
aws_s3_cli_settings_factory: Callable[[], Awaitable[AwsS3CliSettings]],
6262
request: pytest.FixtureRequest,
6363
) -> _SyncSettings:
6464
_rclone_enabled, _aws_s3_cli_enabled = request.param
6565

66-
_r_clone_settings = r_clone_settings if _rclone_enabled else None
67-
_aws_s3_cli_settings = aws_s3_cli_settings if _aws_s3_cli_enabled else None
66+
_r_clone_settings = await r_clone_settings_factory() if _rclone_enabled else None
67+
_aws_s3_cli_settings = (
68+
await aws_s3_cli_settings_factory() if _aws_s3_cli_enabled else None
69+
)
6870

6971
return _SyncSettings(
7072
r_clone_settings=_r_clone_settings, aws_s3_cli_settings=_aws_s3_cli_settings
@@ -82,8 +84,8 @@ def _file_size(size_str: str, **pytest_params):
8284
[
8385
_file_size("10Mib"),
8486
_file_size("103Mib"),
85-
_file_size("1003Mib", marks=pytest.mark.heavy_load),
86-
_file_size("7Gib", marks=pytest.mark.heavy_load),
87+
_file_size("1003Mib"),
88+
_file_size("7Gib"),
8789
],
8890
ids=byte_size_ids,
8991
)

0 commit comments

Comments
 (0)