refactor: replace references to APP_SETTINGS_KEY from constants to application_keys

- Updated imports across multiple modules to source APP_SETTINGS_KEY from application_keys instead of constants.
- This change improves the organization of application keys and reduces potential circular dependencies.

Author: pcrespov

services/web/server/src/simcore_service_webserver/activity/settings.py

@@ -1,7 +1,7 @@
 from aiohttp import web
 from settings_library.prometheus import PrometheusSettings
 
-from ..constants import APP_SETTINGS_KEY
+from ..application_keys import APP_SETTINGS_KEY
 
 
 def get_plugin_settings(app: web.Application) -> PrometheusSettings:

services/web/server/src/simcore_service_webserver/announcements/plugin.py

@@ -6,8 +6,8 @@
 
 from aiohttp import web
 
+from ..application_keys import APP_SETTINGS_KEY
 from ..application_setup import ModuleCategory, app_setup_func
-from ..constants import APP_SETTINGS_KEY
 from ..products.plugin import setup_products
 from ..redis import setup_redis
 from . import _handlers

services/web/server/src/simcore_service_webserver/api_keys/plugin.py

@@ -2,8 +2,8 @@
 
 from aiohttp import web
 
+from ..application_keys import APP_SETTINGS_KEY
 from ..application_setup import ModuleCategory, app_setup_func
-from ..constants import APP_SETTINGS_KEY
 from ..db.plugin import setup_db
 from ..products.plugin import setup_products
 from ..rabbitmq import setup_rabbitmq

services/web/server/src/simcore_service_webserver/application_keys.py

@@ -0,0 +1,32 @@
+"""web.AppKey definitions for simcore_service_webserver"""
+
+from typing import TYPE_CHECKING
+
+from aiohttp import web
+from servicelib.aiohttp.application_keys import (
+    APP_AIOPG_ENGINE_KEY,
+    APP_CLIENT_SESSION_KEY,
+    APP_CONFIG_KEY,
+    APP_FIRE_AND_FORGET_TASKS_KEY,
+)
+
+if TYPE_CHECKING:
+    # Application settings key - defined here to avoid circular imports
+    from .application_settings import ApplicationSettings
+
+    APP_SETTINGS_KEY: web.AppKey[ApplicationSettings] = web.AppKey(
+        "APP_SETTINGS_KEY", ApplicationSettings
+    )
+else:
+    APP_SETTINGS_KEY: web.AppKey = web.AppKey("APP_SETTINGS_KEY", None)
+
+
+__all__: tuple[str, ...] = (
+    "APP_AIOPG_ENGINE_KEY",
+    "APP_CLIENT_SESSION_KEY",
+    "APP_CONFIG_KEY",
+    "APP_FIRE_AND_FORGET_TASKS_KEY",
+    "APP_SETTINGS_KEY",
+)
+
+# nopycln: file

services/web/server/src/simcore_service_webserver/application_settings.py

@@ -28,9 +28,9 @@
 from settings_library.utils_service import DEFAULT_AIOHTTP_PORT
 
 from ._meta import API_VERSION, API_VTAG, APP_NAME
+from .application_keys import APP_SETTINGS_KEY
 from .catalog.settings import CatalogSettings
 from .collaboration.settings import RealTimeCollaborationSettings
-from .constants import APP_SETTINGS_KEY
 from .diagnostics.settings import DiagnosticsSettings
 from .director_v2.settings import DirectorV2Settings
 from .dynamic_scheduler.settings import DynamicSchedulerSettings

services/web/server/src/simcore_service_webserver/application_setup.py

@@ -3,7 +3,7 @@
 
 import servicelib.aiohttp.application_setup
 
-from .constants import APP_SETTINGS_KEY
+from .application_keys import APP_SETTINGS_KEY
 
 # models
 ModuleCategory: TypeAlias = servicelib.aiohttp.application_setup.ModuleCategory

services/web/server/src/simcore_service_webserver/catalog/settings.py

@@ -1,13 +1,13 @@
-""" catalog's subsystem configuration
+"""catalog's subsystem configuration
 
-    - config-file schema
-    - settings
+- config-file schema
+- settings
 """
 
 from aiohttp import web
 from settings_library.catalog import CatalogSettings
 
-from ..constants import APP_SETTINGS_KEY
+from ..application_keys import APP_SETTINGS_KEY
 
 
 def get_plugin_settings(app: web.Application) -> CatalogSettings:

services/web/server/src/simcore_service_webserver/collaboration/settings.py

@@ -7,7 +7,7 @@
 from pydantic.fields import Field
 from settings_library.base import BaseCustomSettings
 
-from ..constants import APP_SETTINGS_KEY
+from ..application_keys import APP_SETTINGS_KEY
 
 
 class RealTimeCollaborationSettings(BaseCustomSettings):

services/web/server/src/simcore_service_webserver/constants.py

@@ -14,21 +14,9 @@
 
 from ._meta import APP_NAME
 
-if TYPE_CHECKING:
-    # Application settings key - defined here to avoid circular imports
-    from .application_settings import ApplicationSettings
-
-    APP_SETTINGS_KEY: web.AppKey[ApplicationSettings] = web.AppKey(
-        "APP_SETTINGS_KEY", ApplicationSettings
-    )
-else:
-    APP_SETTINGS_KEY: web.AppKey = web.AppKey("APP_SETTINGS_KEY", None)
-
-
 assert APP_CLIENT_SESSION_KEY  # nosec
 assert APP_CONFIG_KEY  # nosec
 
-
 # Public config per product returned in /config
 APP_PUBLIC_CONFIG_PER_PRODUCT: Final[str] = f"{__name__}.APP_PUBLIC_CONFIG_PER_PRODUCT"
 

services/web/server/src/simcore_service_webserver/conversations/_controller/_conversations_messages_rest.py

@@ -31,7 +31,7 @@
 from servicelib.rest_constants import RESPONSE_MODEL_POLICY
 
 from ..._meta import API_VTAG as VTAG
-from ...constants import APP_SETTINGS_KEY
+from ...application_keys import APP_SETTINGS_KEY
 from ...email import email_service
 from ...fogbugz.settings import FogbugzSettings
 from ...login.decorators import login_required