Skip to content

Commit 1588e21

Browse files
committed
updates db queries
1 parent 93c2599 commit 1588e21

File tree

3 files changed

+15
-1
lines changed

3 files changed

+15
-1
lines changed

services/web/server/src/simcore_service_webserver/users/_accounts_repository.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -390,10 +390,15 @@ async def search_merged_pre_and_registered_users(
390390
invited_by,
391391
account_request_reviewed_by_username, # account_request_reviewed_by converted to username
392392
users_pre_registration_details.c.created,
393+
users.c.id.label("user_id"),
394+
users.c.name.label("user_name"),
395+
users.c.primary_gid.label("user_primary_group_id"),
393396
)
394397

395398
left_outer_join = _build_left_outer_join_query(
396-
filter_by_email_like, product_name, columns
399+
filter_by_email_like,
400+
product_name,
401+
columns,
397402
)
398403
right_outer_join = _build_right_outer_join_query(
399404
filter_by_email_like,
@@ -494,6 +499,7 @@ async def list_merged_pre_and_registered_users(
494499
users_pre_registration_details.c.account_request_reviewed_at,
495500
users.c.id.label("user_id"),
496501
users.c.name.label("user_name"),
502+
users.c.primary_gid.label("user_primary_group_id"),
497503
users.c.status,
498504
# Use created_by directly instead of a subquery
499505
users_pre_registration_details.c.created_by.label("created_by"),
@@ -530,6 +536,7 @@ async def list_merged_pre_and_registered_users(
530536
sa.literal(None).label("account_request_reviewed_at"),
531537
users.c.id.label("user_id"),
532538
users.c.name.label("user_name"),
539+
users.c.primary_gid.label("user_primary_group_id"),
533540
users.c.status,
534541
# Match the created_by field from the pre_reg query
535542
sa.literal(None).label("created_by"),

services/web/server/src/simcore_service_webserver/users/_accounts_service.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -223,6 +223,10 @@ async def _list_products_or_none(user_id):
223223
# NOTE: old users will not have extra details
224224
registered=r.user_id is not None if r.pre_email else r.status is not None,
225225
status=r.status,
226+
# user
227+
user_id=r.user_id,
228+
user_name=r.user_name,
229+
user_primary_group_id=r.primary_group_id,
226230
)
227231
for r in rows
228232
]

services/web/server/tests/unit/with_dbs/03/invitations/test_users_accounts_rest_registration.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -261,6 +261,9 @@ async def test_search_and_pre_registration(
261261
"extras": {},
262262
"registered": True,
263263
"status": UserStatus.ACTIVE,
264+
"user_id": logged_user["id"],
265+
"user_name": logged_user["name"],
266+
"user_primary_group_id": logged_user.get("primary_group_id"),
264267
}
265268
assert got.model_dump(include=set(expected)) == expected
266269

0 commit comments

Comments
 (0)