fixes invisible issues

Author: sanderegg

packages/service-library/src/servicelib/background_task.py

@@ -10,7 +10,7 @@
 from tenacity.wait import wait_fixed
 
 from .async_utils import cancel_wait_task, delayed_start
-from .logging_utils import log_context
+from .logging_utils import log_catch, log_context
 
 _logger = logging.getLogger(__name__)
 
@@ -84,7 +84,8 @@ class _InternalTryAgain(TryAgain):
         )
         @functools.wraps(func)
         async def _wrapper(*args: P.args, **kwargs: P.kwargs) -> None:
-            await func(*args, **kwargs)
+            with log_catch(_logger, reraise=True):
+                await func(*args, **kwargs)
             raise _InternalTryAgain
 
         return _wrapper

packages/service-library/tests/test_background_task.py

@@ -6,6 +6,7 @@
 
 import asyncio
 import datetime
+import logging
 from collections.abc import AsyncIterator, Awaitable, Callable
 from typing import Final
 from unittest import mock
@@ -204,3 +205,19 @@ async def _func() -> None:
         await task
 
     assert mock_func.call_count > 1
+
+
+async def test_periodic_task_logs_error(
+    mock_background_task: mock.AsyncMock,
+    task_interval: datetime.timedelta,
+    caplog: pytest.LogCaptureFixture,
+):
+    mock_background_task.side_effect = RuntimeError("Test error")
+
+    with caplog.at_level(logging.ERROR):
+        async with periodic_task(
+            mock_background_task, interval=task_interval, task_name="test_task"
+        ):
+            await asyncio.sleep(2 * task_interval.total_seconds())
+
+    assert "Test error" in caplog.text