fix tests

Author: pcrespov

services/web/server/src/simcore_service_webserver/login/_2fa_api.py

@@ -1,4 +1,4 @@
-""" two-factor-authentication utils
+"""two-factor-authentication utils
 
 Currently includes two parts:
 
@@ -10,14 +10,14 @@
 import asyncio
 import logging
 
+import twilio.rest
 from aiohttp import web
 from models_library.users import UserID
 from pydantic import BaseModel, Field
 from servicelib.logging_utils import log_decorator
 from servicelib.utils_secrets import generate_passcode
 from settings_library.twilio import TwilioSettings
 from twilio.base.exceptions import TwilioException  # type: ignore[import-untyped]
-from twilio.rest import Client  # type: ignore[import-untyped]
 
 from ..login.errors import SendingVerificationEmailError, SendingVerificationSmsError
 from ..products.models import Product
@@ -118,7 +118,8 @@ def _sender():
             #
             # SEE https://www.twilio.com/docs/sms/quickstart/python
             #
-            client = Client(
+            # NOTE: this is mocked
+            client = twilio.rest.Client(
                 twilio_auth.TWILIO_ACCOUNT_SID, twilio_auth.TWILIO_AUTH_TOKEN
             )
             message = client.messages.create(**create_kwargs)

services/web/server/tests/unit/with_dbs/03/login/test_login_2fa.py

@@ -36,6 +36,7 @@
 )
 from simcore_service_webserver.login.storage import AsyncpgStorage
 from simcore_service_webserver.products import products_web
+from simcore_service_webserver.products.errors import UnknownProductError
 from simcore_service_webserver.products.models import Product
 from simcore_service_webserver.users import preferences_api as user_preferences_api
 from twilio.base.exceptions import TwilioRestException
@@ -370,7 +371,7 @@ async def test_send_email_code(
 ):
     request = make_mocked_request("GET", "/dummy", app=client.app)
 
-    with pytest.raises(KeyError):
+    with pytest.raises(UnknownProductError):
         # NOTE: this is a fake request and did not go through middlewares
         products_web.get_current_product(request)
 
@@ -418,9 +419,9 @@ async def test_2fa_sms_failure_during_login(
 ):
     assert client.app
 
-    # Mocks error in graylog https://monitoring.osparc.io/graylog/search/649e7619ce6e0838a96e9bf1?q=%222FA%22&rangetype=relative&from=172800
     mocker.patch(
-        "simcore_service_webserver.login._2fa_api.TwilioSettings.is_alphanumeric_supported",
+        # MD: Emulates error in graylog https://monitoring.osparc.io/graylog/search/649e7619ce6e0838a96e9bf1?q=%222FA%22&rangetype=relative&from=172800
+        "simcore_service_webserver.login._2fa_api.twilio.rest.Client",
         autospec=True,
         side_effect=TwilioRestException(
             status=400,