fixed test

Author: Andrei Neagu

services/dynamic-scheduler/tests/unit/api_frontend/conftest.py

@@ -5,6 +5,8 @@
 import subprocess
 from collections.abc import AsyncIterable
 from contextlib import suppress
+from typing import Final
+from unittest.mock import AsyncMock
 
 import pytest
 from fastapi import FastAPI, status
@@ -16,15 +18,36 @@
 from pytest_simcore.helpers.typing_env import EnvVarsDict
 from settings_library.rabbit import RabbitSettings
 from settings_library.redis import RedisSettings
+from settings_library.utils_service import DEFAULT_FASTAPI_PORT
 from simcore_service_dynamic_scheduler.core.application import create_app
 from tenacity import AsyncRetrying, stop_after_delay, wait_fixed
 
+_MODULE: Final["str"] = "simcore_service_dynamic_scheduler"
+
 
 @pytest.fixture
 def disable_status_monitor_background_task(mocker: MockerFixture) -> None:
     mocker.patch(
-        "simcore_service_dynamic_scheduler.services.status_monitor._monitor.Monitor._worker_check_services_require_status_update"
+        f"{_MODULE}.services.status_monitor._monitor.Monitor._worker_check_services_require_status_update"
+    )
+
+
+@pytest.fixture
+def mock_stop_dynamic_service(mocker: MockerFixture) -> AsyncMock:
+    async_mock = AsyncMock()
+    mocker.patch(
+        f"{_MODULE}.api.frontend.routes._service.stop_dynamic_service", async_mock
+    )
+    return async_mock
+
+
+@pytest.fixture
+def mock_remove_tracked_service(mocker: MockerFixture) -> AsyncMock:
+    async_mock = AsyncMock()
+    mocker.patch(
+        f"{_MODULE}.api.frontend.routes._service.remove_tracked_service", async_mock
     )
+    return async_mock
 
 
 @pytest.fixture
@@ -40,7 +63,7 @@ def app_environment(
 
 @pytest.fixture
 def server_host_port() -> str:
-    return "127.0.0.1:7456"
+    return f"127.0.0.1:{DEFAULT_FASTAPI_PORT}"
 
 
 @pytest.fixture

services/dynamic-scheduler/tests/unit/api_frontend/test_api_frontend_routes_index.py

@@ -2,6 +2,7 @@
 # pylint:disable=unused-argument
 
 from collections.abc import Callable
+from unittest.mock import AsyncMock
 from uuid import uuid4
 
 import pytest
@@ -21,6 +22,7 @@
     set_request_as_running,
     set_request_as_stopped,
 )
+from tenacity import AsyncRetrying, stop_after_delay, wait_fixed
 
 pytest_simcore_core_services_selection = [
     "rabbit",
@@ -89,6 +91,7 @@ async def test_main_page(
     service_status: NodeGet | DynamicServiceGet,
     not_initialized_app: FastAPI,
     get_dynamic_service_start: Callable[[NodeID], DynamicServiceStart],
+    mock_stop_dynamic_service: AsyncMock,
 ):
     await async_page.goto(server_host_port)
 
@@ -124,6 +127,11 @@ async def test_main_page(
     await assert_contains_text(
         async_page, "The service will be stopped and its data will be saved"
     )
-    await click_on_text(async_page, "Stop Now")
 
-    # TODO: assert called on backend
+    mock_stop_dynamic_service.assert_not_awaited()
+    await click_on_text(async_page, "Stop Now")
+    async for attempt in AsyncRetrying(
+        reraise=True, wait=wait_fixed(0.1), stop=stop_after_delay(3)
+    ):
+        with attempt:
+            mock_stop_dynamic_service.assert_awaited_once()