worker does not allow for async call into log_event

Author: sanderegg

services/dask-sidecar/src/simcore_service_dask_sidecar/utils/dask.py

@@ -6,7 +6,6 @@
 from typing import Final
 
 import distributed
-from common_library.async_tools import maybe_await
 from dask_task_models_library.container_tasks.errors import TaskCancelledError
 from dask_task_models_library.container_tasks.events import (
     BaseTaskEvent,
@@ -75,7 +74,6 @@ def publish_progress(self, report: ProgressReport) -> None:
         if rounded_value > self._last_published_progress_value:
             with log_catch(logger=_logger, reraise=False):
                 publish_event(
-                    self.progress,
                     TaskProgressEvent.from_dask_worker(
                         progress=rounded_value, task_owner=self.task_owner
                     ),
@@ -170,7 +168,7 @@ async def periodicaly_check_if_aborted(task_name: str) -> None:
                 await periodically_checking_task
 
 
-async def publish_event(
+def publish_event(
     event: BaseTaskEvent,
 ) -> None:
     """never reraises, only CancellationError"""
@@ -180,6 +178,4 @@ async def publish_event(
         log_catch(_logger, reraise=False),
         log_context(_logger, logging.DEBUG, msg=f"publishing {event=}"),
     ):
-        await maybe_await(
-            worker.log_event(TaskProgressEvent.topic_name(), event.model_dump_json())
-        )
+        worker.log_event(TaskProgressEvent.topic_name(), event.model_dump_json())

services/dask-sidecar/tests/unit/test_utils_dask.py

@@ -75,7 +75,7 @@ def _worker_task() -> int:
 
             async def _() -> int:
                 with log_context(logging.INFO, "_worker_task_async"):
-                    await publish_event(event_to_publish)
+                    publish_event(event_to_publish)
                     return 2
 
             return asyncio.run(_())