no need to double catch

Author: sanderegg

packages/service-library/src/servicelib/rabbitmq/_client.py

@@ -46,7 +46,6 @@ def _get_x_death_count(message: aio_pika.abc.AbstractIncomingMessage) -> int:
         and isinstance(x_death[0], dict)
         and "count" in x_death[0]
     ):
-
         assert isinstance(x_death[0]["count"], int)  # nosec
         count = x_death[0]["count"]
 
@@ -96,7 +95,9 @@ async def _on_message(
                 if not await message_handler(message.body):
                     await _safe_nack(message_handler, max_retries_upon_error, message)
         except Exception:  # pylint: disable=broad-exception-caught
-            _logger.exception("Exception raised when handling message")
+            _logger.exception(
+                "Exception raised when handling message. This is catched and will continue. TIP: review your code"
+            )
             with log_catch(_logger, reraise=False):
                 await _safe_nack(message_handler, max_retries_upon_error, message)
 

services/web/server/src/simcore_service_webserver/notifications/_rabbitmq_exclusive_queue_consumers.py

@@ -44,13 +44,12 @@
 async def _notify_comp_node_progress(
     app: web.Application, message: ProgressRabbitMessageNode
 ) -> None:
-    with log_catch(_logger, reraise=False):
-        project = await _projects_service.get_project_for_user(
-            app, f"{message.project_id}", message.user_id, include_state=True
-        )
-        await _projects_service.notify_project_node_update(
-            app, project, message.node_id, None
-        )
+    project = await _projects_service.get_project_for_user(
+        app, f"{message.project_id}", message.user_id, include_state=True
+    )
+    await _projects_service.notify_project_node_update(
+        app, project, message.node_id, None
+    )
 
 
 async def _progress_message_parser(app: web.Application, data: bytes) -> bool: