Skip to content

Commit 18ca9c9

Browse files
Merge branch 'is4481/upgrade-libs' into is4481/upgrade-services
2 parents b625366 + 42f07ea commit 18ca9c9

File tree

5 files changed

+20
-14
lines changed

5 files changed

+20
-14
lines changed

packages/models-library/src/models_library/projects_nodes_io.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"""
88

99
from pathlib import Path
10-
from typing import Annotated, TypeAlias
10+
from typing import Annotated, Final, TypeAlias
1111
from uuid import UUID
1212

1313
from models_library.basic_types import ConstrainedStr, KeyIDStr
@@ -45,7 +45,7 @@
4545
]
4646

4747

48-
_ANY_URL_ADAPTER: TypeAdapter[AnyUrl] = TypeAdapter(AnyUrl)
48+
_ANY_URL_ADAPTER: Final[TypeAdapter[AnyUrl]] = TypeAdapter(AnyUrl)
4949

5050

5151
class SimcoreS3DirectoryID(ConstrainedStr):

packages/simcore-sdk/tests/unit/test_node_ports_common_file_io_utils.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
UploadedPart,
2020
)
2121
from moto.server import ThreadedMotoServer
22-
from pydantic import AnyUrl, ByteSize, TypeAdapter, parse_obj_as
22+
from pydantic import AnyUrl, ByteSize, TypeAdapter
2323
from pytest_mock import MockerFixture
2424
from servicelib.aiohttp import status
2525
from servicelib.progress_bar import ProgressBarData
@@ -212,8 +212,7 @@ async def _creator(num_upload_links: int, chunk_size: ByteSize) -> FileUploadSch
212212
assert "UploadId" in response
213213
upload_id = response["UploadId"]
214214

215-
upload_links = parse_obj_as(
216-
list[AnyUrl],
215+
upload_links = TypeAdapter(list[AnyUrl]).validate_python(
217216
await asyncio.gather(
218217
*[
219218
aiobotocore_s3_client.generate_presigned_url(
@@ -258,6 +257,7 @@ async def test_upload_file_to_presigned_links(
258257
create_file_of_size: Callable[[ByteSize], Path],
259258
file_size: ByteSize,
260259
used_chunk_size: ByteSize,
260+
faker: Faker,
261261
):
262262
"""This test is here to reproduce the issue https://github.com/ITISFoundation/osparc-simcore/issues/3531
263263
One theory is that something might be wrong in how the chunking is done and that AWS times out
@@ -272,11 +272,11 @@ async def test_upload_file_to_presigned_links(
272272
"""
273273
local_file = create_file_of_size(file_size)
274274
num_links = 2080
275-
effective_chunk_size = parse_obj_as(ByteSize, local_file.stat().st_size / num_links)
275+
effective_chunk_size = TypeAdapter(ByteSize).validate_python(local_file.stat().st_size / num_links)
276276
assert effective_chunk_size <= used_chunk_size
277277
upload_links = await create_upload_links(num_links, used_chunk_size)
278278
assert len(upload_links.urls) == num_links
279-
async with ProgressBarData(num_steps=1) as progress_bar:
279+
async with ProgressBarData(num_steps=1, description=faker.pystr()) as progress_bar:
280280
uploaded_parts: list[UploadedPart] = await upload_file_to_presigned_links(
281281
session=client_session,
282282
file_upload_links=upload_links,

packages/simcore-sdk/tests/unit/test_node_ports_v2_nodeports_v2.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ async def mock_node_port_creator_cb(*args, **kwargs):
5050
user_id=user_id,
5151
project_id=project_id,
5252
node_uuid=node_uuid,
53+
io_log_redirect_cb=None,
5354
save_to_db_cb=mock_save_db_cb,
5455
node_port_creator_cb=mock_node_port_creator_cb,
5556
auto_update=False,
@@ -62,6 +63,7 @@ async def mock_node_port_creator_cb(*args, **kwargs):
6263
user_id=user_id,
6364
project_id=project_id,
6465
node_uuid=node_uuid,
66+
io_log_redirect_cb=None,
6567
save_to_db_cb=mock_save_db_cb,
6668
node_port_creator_cb=mock_node_port_creator_cb,
6769
auto_update=auto_update,
@@ -101,6 +103,7 @@ async def mock_node_port_creator_cb(*args, **kwargs):
101103
user_id=user_id,
102104
project_id=project_id,
103105
node_uuid=node_uuid,
106+
io_log_redirect_cb=None,
104107
save_to_db_cb=mock_save_db_cb,
105108
node_port_creator_cb=mock_node_port_creator_cb,
106109
auto_update=False,
@@ -113,6 +116,7 @@ async def mock_node_port_creator_cb(*args, **kwargs):
113116
user_id=user_id,
114117
project_id=project_id,
115118
node_uuid=node_uuid,
119+
io_log_redirect_cb=None,
116120
save_to_db_cb=mock_save_db_cb,
117121
node_port_creator_cb=mock_node_port_creator_cb,
118122
auto_update=False,
@@ -182,6 +186,7 @@ async def mock_node_port_creator_cb(*args, **kwargs):
182186
user_id=user_id,
183187
project_id=project_id,
184188
node_uuid=node_uuid,
189+
io_log_redirect_cb=None,
185190
save_to_db_cb=mock_save_db_cb,
186191
node_port_creator_cb=mock_node_port_creator_cb,
187192
auto_update=False,
@@ -194,6 +199,7 @@ async def mock_node_port_creator_cb(*args, **kwargs):
194199
user_id=user_id,
195200
project_id=project_id,
196201
node_uuid=node_uuid,
202+
io_log_redirect_cb=None,
197203
save_to_db_cb=mock_save_db_cb,
198204
node_port_creator_cb=mock_node_port_creator_cb,
199205
auto_update=False,

packages/simcore-sdk/tests/unit/test_node_ports_v2_port.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -341,7 +341,7 @@ class PortParams(NamedTuple):
341341
exp_new_value=FileLink(
342342
store=simcore_store_id(),
343343
path=f"{project_id()}/{node_uuid()}/no_file_with_default/{this_node_file_name().name}",
344-
eTag=e_tag(),
344+
e_tag=e_tag(),
345345
),
346346
exp_new_get_value=download_file_folder_name()
347347
/ "no_file_with_default"
@@ -429,7 +429,7 @@ class PortParams(NamedTuple):
429429
exp_new_value=FileLink(
430430
store=simcore_store_id(),
431431
path=f"{project_id()}/{node_uuid()}/some_file_on_datcore/{this_node_file_name().name}",
432-
eTag=e_tag(),
432+
e_tag=e_tag(),
433433
),
434434
exp_new_get_value=download_file_folder_name()
435435
/ "some_file_on_datcore"
@@ -458,7 +458,7 @@ class PortParams(NamedTuple):
458458
exp_new_value=FileLink(
459459
store=simcore_store_id(),
460460
path=f"{project_id()}/{node_uuid()}/download_link/{this_node_file_name().name}",
461-
eTag=e_tag(),
461+
e_tag=e_tag(),
462462
),
463463
exp_new_get_value=download_file_folder_name()
464464
/ "download_link"
@@ -490,7 +490,7 @@ class PortParams(NamedTuple):
490490
exp_new_value=FileLink(
491491
store=simcore_store_id(),
492492
path=f"{project_id()}/{node_uuid()}/download_link_with_file_to_key/{this_node_file_name().name}",
493-
eTag=e_tag(),
493+
e_tag=e_tag(),
494494
),
495495
exp_new_get_value=download_file_folder_name()
496496
/ "download_link_with_file_to_key"
@@ -521,7 +521,7 @@ class PortParams(NamedTuple):
521521
exp_new_value=FileLink(
522522
store=simcore_store_id(),
523523
path=f"{project_id()}/{node_uuid()}/file_port_link/{this_node_file_name().name}",
524-
eTag=e_tag(),
524+
e_tag=e_tag(),
525525
),
526526
exp_new_get_value=download_file_folder_name()
527527
/ "file_port_link"
@@ -555,7 +555,7 @@ class PortParams(NamedTuple):
555555
exp_new_value=FileLink(
556556
store=simcore_store_id(),
557557
path=f"{project_id()}/{node_uuid()}/file_port_link_with_file_to_key_map/{this_node_file_name().name}",
558-
eTag=e_tag(),
558+
e_tag=e_tag(),
559559
),
560560
exp_new_get_value=download_file_folder_name()
561561
/ "file_port_link_with_file_to_key_map"

packages/simcore-sdk/tests/unit/test_node_ports_v2_port_validation.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
import pytest
1616
from pydantic import BaseModel, Field, schema_of
17-
from pydantic.error_wrappers import ValidationError
17+
from pydantic import ValidationError
1818
from simcore_sdk.node_ports_v2.port import Port
1919
from simcore_sdk.node_ports_v2.port_validation import (
2020
PortUnitError,

0 commit comments

Comments
 (0)