Skip to content

Commit 1942489

Browse files
committed
Refactor function tests based on pr comments
1 parent a472249 commit 1942489

File tree

6 files changed

+335
-650
lines changed

6 files changed

+335
-650
lines changed

packages/models-library/src/models_library/api_schemas_webserver/functions_wb_schema.py

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -210,46 +210,32 @@ class FunctionBaseError(OsparcErrorMixin, Exception):
210210

211211

212212
class FunctionIDNotFoundError(FunctionBaseError):
213-
"""Exception raised when a function is not found"""
214-
215213
msg_template: str = "Function {function_id} not found"
216214

217215

218216
class FunctionJobIDNotFoundError(FunctionBaseError):
219-
"""Exception raised when a function job is not found"""
220-
221217
msg_template: str = "Function job {function_job_id} not found"
222218

223219

224220
class FunctionJobCollectionIDNotFoundError(FunctionBaseError):
225-
"""Exception raised when a function job collection is not found"""
226-
227221
msg_template: str = "Function job collection {function_job_collection_id} not found"
228222

229223

230224
class UnsupportedFunctionClassError(FunctionBaseError):
231-
"""Exception raised when a function class is not supported"""
232-
233225
msg_template: str = "Function class {function_class} is not supported"
234226

235227

236228
class UnsupportedFunctionJobClassError(FunctionBaseError):
237-
"""Exception raised when a function job class is not supported"""
238-
239229
msg_template: str = "Function job class {function_job_class} is not supported"
240230

241231

242232
class UnsupportedFunctionFunctionJobClassCombinationError(FunctionBaseError):
243-
"""Exception raised when a function / function job class combination is not supported"""
244-
245233
msg_template: str = (
246234
"Function class {function_class} and function job class {function_job_class} combination is not supported"
247235
)
248236

249237

250238
class FunctionInputsValidationError(FunctionBaseError):
251-
"""Exception raised when validating function inputs"""
252-
253239
msg_template: str = "Function inputs validation failed: {error}"
254240

255241

packages/postgres-database/src/simcore_postgres_database/models/funcapi_function_job_collections_table.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,3 @@
1-
"""Functions table
2-
3-
- List of functions served by the simcore platform
4-
"""
5-
61
import uuid
72

83
import sqlalchemy as sa

packages/postgres-database/src/simcore_postgres_database/models/funcapi_function_jobs_table.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
"""Functions table
1+
"""Function jobs table
22
3-
- List of functions served by the simcore platform
3+
- List of function jobs served by the simcore platform
44
"""
55

66
import uuid

0 commit comments

Comments
 (0)