Skip to content

Commit 1948db3

Browse files
committed
cleanup tests
1 parent 5676c86 commit 1948db3

File tree

1 file changed

+18
-12
lines changed

1 file changed

+18
-12
lines changed

services/web/server/tests/unit/with_dbs/01/groups/test_groups_handlers_users.py

Lines changed: 18 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
)
3232
from simcore_service_webserver.groups.api import auto_add_user_to_groups
3333
from simcore_service_webserver.security.api import clean_auth_policy_cache
34-
from simcore_service_webserver.utils import gravatar_hash
3534

3635

3736
def _assert_group(group: dict[str, str]):
@@ -43,19 +42,26 @@ def _assert__group_user(
4342
expected_access_rights: AccessRightsDict,
4443
actual_user: dict,
4544
):
46-
assert "first_name" in actual_user
47-
assert actual_user["first_name"] == expected_user.get("first_name")
48-
assert "last_name" in actual_user
49-
assert actual_user["last_name"] == expected_user.get("last_name")
50-
assert "login" in actual_user
51-
assert actual_user["login"] == expected_user["email"]
52-
assert "gravatar_id" in actual_user
53-
assert actual_user["gravatar_id"] == gravatar_hash(expected_user["email"])
54-
assert "accessRights" in actual_user
55-
assert actual_user["accessRights"] == expected_access_rights
45+
# identifiers
46+
assert actual_user["userName"] == expected_user["name"]
47+
5648
assert "id" in actual_user
57-
assert actual_user["id"] == expected_user["id"]
49+
assert int(actual_user["id"]) == expected_user["id"]
50+
5851
assert "gid" in actual_user
52+
assert int(actual_user["gid"]) == expected_user.get("primary_id")
53+
54+
# privacy
55+
# assert "first_name" in actual_user
56+
# assert actual_user["first_name"] == expected_user.get("first_name")
57+
# assert "last_name" in actual_user
58+
# assert actual_user["last_name"] == expected_user.get("last_name")
59+
# assert "login" in actual_user
60+
# assert actual_user["login"] == expected_user["email"]
61+
62+
# access-rights
63+
assert "accessRights" in actual_user
64+
assert actual_user["accessRights"] == expected_access_rights
5965

6066

6167
@pytest.mark.parametrize(*standard_role_response())

0 commit comments

Comments
 (0)