feat: add readFunctions when getting permissions

Author: giancarloromeo

packages/models-library/src/models_library/api_schemas_webserver/users.py

@@ -407,4 +407,5 @@ def from_domain_model(cls, permission: UserPermission) -> Self:
 
 
 class MyFunctionPermissionsGet(OutputSchema):
+    read_functions: bool
     write_functions: bool

services/web/server/src/simcore_service_webserver/functions/_controller/_functions_rest.py

@@ -125,5 +125,8 @@ async def list_user_functions_permissions(request: web.Request) -> web.Response:
     assert function_permissions.user_id == req_ctx.user_id  # nosec
 
     return envelope_json_response(
-        MyFunctionPermissionsGet(write_functions=function_permissions.write_functions)
+        MyFunctionPermissionsGet(
+            read_functions=function_permissions.read_functions,
+            write_functions=function_permissions.write_functions,
+        )
     )

services/web/server/tests/unit/with_dbs/04/functions_rpc/conftest.py

@@ -200,6 +200,7 @@ async def logged_user_function_api_access_rights(
     asyncpg_engine: AsyncEngine,
     logged_user: UserInfoDict,
     *,
+    expected_read_functions: bool,
     expected_write_functions: bool,
 ) -> AsyncIterator[dict[str, Any]]:
     cm = insert_and_get_row_lifespan(
@@ -208,7 +209,7 @@ async def logged_user_function_api_access_rights(
         values={
             "group_id": logged_user["primary_gid"],
             "product_name": FRONTEND_APP_DEFAULT,
-            "read_functions": True,
+            "read_functions": expected_read_functions,
             "write_functions": expected_write_functions,
             "execute_functions": True,
             "read_function_jobs": True,

services/web/server/tests/unit/with_dbs/04/functions_rpc/test_functions_controller_rest.py

@@ -115,13 +115,26 @@ async def test_register_get_delete_function(
 
 
 @pytest.mark.parametrize("user_role", [UserRole.USER])
-@pytest.mark.parametrize("expected_write_functions", [True, False])
+@pytest.mark.parametrize(
+    "expected_read_functions,expected_write_functions",
+    [
+        (True, True),
+        (True, False),
+        (False, True),  # Weird, but allowed for testing purposes
+        (False, False),
+    ],
+)
 async def test_list_user_functions_permissions(
     client: TestClient,
     logged_user: UserInfoDict,
+    expected_read_functions: bool,
     expected_write_functions: bool,
     logged_user_function_api_access_rights: dict[str, Any],
 ):
+    assert (
+        logged_user_function_api_access_rights["read_functions"]
+        == expected_read_functions
+    )
     assert (
         logged_user_function_api_access_rights["write_functions"]
         == expected_write_functions
@@ -133,4 +146,5 @@ async def test_list_user_functions_permissions(
 
     assert not error
     function_permissions = MyFunctionPermissionsGet.model_validate(data)
+    assert function_permissions.read_functions == expected_read_functions
     assert function_permissions.write_functions == expected_write_functions