fix: address display name default

Author: giancarloromeo

packages/models-library/src/models_library/rpc/notifications/channels/_email_channel.py

@@ -4,7 +4,7 @@
 
 
 class EmailAddress(BaseModel):
-    display_name: str | None = None
+    display_name: str = ""
     addr_spec: EmailStr
 
 

services/notifications/tests/unit/conftest.py

@@ -14,6 +14,7 @@
 from celery.signals import worker_init, worker_shutdown
 from celery.worker.worker import WorkController
 from celery_library.signals import on_worker_init, on_worker_shutdown
+from faker import Faker
 from fastapi import FastAPI
 from fastapi.testclient import TestClient
 from pytest_mock import MockerFixture
@@ -152,3 +153,12 @@ async def notifications_rabbitmq_rpc_client(
 @pytest.fixture
 def test_client(fastapi_app: FastAPI) -> TestClient:
     return TestClient(fastapi_app)
+
+
+@pytest.fixture
+def fake_ipinfo(faker: Faker) -> dict[str, Any]:
+    return {
+        "x-real-ip": faker.ipv4(),
+        "x-forwarded-for": faker.ipv4(),
+        "peername": faker.ipv4(),
+    }

services/notifications/tests/unit/test_send_email_tasks.py

@@ -1,3 +1,5 @@
+from typing import Any
+
 import pytest
 from faker import Faker
 from models_library.rpc.notifications import Notification
@@ -28,6 +30,7 @@
 )
 async def test_account_requested(
     notifications_rabbitmq_rpc_client: RabbitMQRPCClient,
+    fake_ipinfo: dict[str, Any],
     faker: Faker,
 ):
     user_email = faker.email()
@@ -55,6 +58,7 @@ async def test_account_requested(
                     ),
                 ),
                 host=HttpUrl(faker.url()),
+                ipinfo=fake_ipinfo,
             ),
             channel=EmailChannel(
                 from_addr=EmailAddress(addr_spec=faker.email()),
@@ -103,8 +107,11 @@ async def test_account_approved(
                 link=HttpUrl(faker.url()),
             ),
             channel=EmailChannel(
-                from_addr=EmailAddress(addr_spec=faker.email()),
+                from_addr=EmailAddress(
+                    display_name=faker.name(), addr_spec=faker.email()
+                ),
                 to_addr=EmailAddress(
+                    display_name=faker.name(),
                     addr_spec=user_email,
                 ),
             ),