Skip to content

Commit 1a73ba0

Browse files
continue upgrading
1 parent 36cda93 commit 1a73ba0

File tree

5 files changed

+25
-30
lines changed

5 files changed

+25
-30
lines changed

services/autoscaling/src/simcore_service_autoscaling/_meta.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
from typing import Final
22

3+
from pydantic import TypeAdapter
4+
35
from models_library.basic_types import VersionStr, VersionTag
46
from packaging.version import Version
57
from servicelib.utils_meta import PackageInfo
@@ -10,7 +12,7 @@
1012
APP_NAME: Final[str] = info.project_name
1113
API_VERSION: Final[VersionStr] = info.__version__
1214
VERSION: Final[Version] = info.version
13-
API_VTAG: Final[VersionTag] = VersionTag(info.api_prefix_path_tag)
15+
API_VTAG: Final[VersionTag] = TypeAdapter(VersionTag).validate_python(info.api_prefix_path_tag)
1416
SUMMARY: Final[str] = info.get_summary()
1517

1618

services/autoscaling/src/simcore_service_autoscaling/constants.py

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,32 +2,34 @@
22
from typing import Final
33

44
from aws_library.ec2._models import AWSTagKey, AWSTagValue, EC2Tags
5-
from pydantic import parse_obj_as
5+
from pydantic import TypeAdapter
66

7-
BUFFER_MACHINE_PULLING_EC2_TAG_KEY: Final[AWSTagKey] = parse_obj_as(
8-
AWSTagKey, "pulling"
7+
BUFFER_MACHINE_PULLING_EC2_TAG_KEY: Final[AWSTagKey] = TypeAdapter(AWSTagKey).validate_python(
8+
"pulling"
99
)
10-
BUFFER_MACHINE_PULLING_COMMAND_ID_EC2_TAG_KEY: Final[AWSTagKey] = parse_obj_as(
11-
AWSTagKey, "ssm-command-id"
10+
BUFFER_MACHINE_PULLING_COMMAND_ID_EC2_TAG_KEY: Final[AWSTagKey] = TypeAdapter(AWSTagKey).validate_python(
11+
"ssm-command-id"
1212
)
1313
PREPULL_COMMAND_NAME: Final[str] = "docker images pulling"
1414

1515
DOCKER_PULL_COMMAND: Final[
1616
str
1717
] = "docker compose -f /docker-pull.compose.yml -p buffering pull"
1818

19-
PRE_PULLED_IMAGES_EC2_TAG_KEY: Final[AWSTagKey] = parse_obj_as(
20-
AWSTagKey, "io.simcore.autoscaling.pre_pulled_images"
19+
PRE_PULLED_IMAGES_EC2_TAG_KEY: Final[AWSTagKey] = TypeAdapter(AWSTagKey).validate_python(
20+
"io.simcore.autoscaling.pre_pulled_images"
2121
)
2222

23-
BUFFER_MACHINE_TAG_KEY: Final[AWSTagKey] = parse_obj_as(
24-
AWSTagKey, "io.simcore.autoscaling.buffer_machine"
23+
BUFFER_MACHINE_TAG_KEY: Final[AWSTagKey] = TypeAdapter(AWSTagKey).validate_python(
24+
"io.simcore.autoscaling.buffer_machine"
2525
)
2626
DEACTIVATED_BUFFER_MACHINE_EC2_TAGS: Final[EC2Tags] = {
27-
BUFFER_MACHINE_TAG_KEY: parse_obj_as(AWSTagValue, "true")
27+
BUFFER_MACHINE_TAG_KEY: TypeAdapter(AWSTagValue).validate_python(
28+
"true"
29+
)
2830
}
2931
ACTIVATED_BUFFER_MACHINE_EC2_TAGS: Final[EC2Tags] = {
30-
BUFFER_MACHINE_TAG_KEY: parse_obj_as(AWSTagValue, "false")
32+
BUFFER_MACHINE_TAG_KEY: TypeAdapter(AWSTagValue).validate_python("false")
3133
}
3234
PRE_PULLED_IMAGES_RE: Final[re.Pattern] = re.compile(
3335
rf"{PRE_PULLED_IMAGES_EC2_TAG_KEY}_\((\d+)\)"

services/autoscaling/src/simcore_service_autoscaling/core/errors.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,7 @@
1-
from typing import Any
2-
31
from models_library.errors_classes import OsparcErrorMixin
42

53

64
class AutoscalingRuntimeError(OsparcErrorMixin, RuntimeError):
7-
def __init__(self, **ctx: Any) -> None:
8-
super().__init__(**ctx)
9-
105
msg_template: str = "Autoscaling unexpected error"
116

127

services/autoscaling/src/simcore_service_autoscaling/core/settings.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import datetime
22
from functools import cached_property
3-
from typing import Final, cast
3+
from typing import Annotated, Final, cast
44

55
from aws_library.ec2 import EC2InstanceBootSpecific, EC2Tags
66
from fastapi import FastAPI
@@ -183,7 +183,7 @@ class NodesMonitoringSettings(BaseCustomSettings):
183183

184184

185185
class DaskMonitoringSettings(BaseCustomSettings):
186-
DASK_MONITORING_URL: AnyUrl = Field(
186+
DASK_MONITORING_URL: Annotated[str, AnyUrl] = Field(
187187
..., description="the url to the osparc-dask-scheduler"
188188
)
189189
DASK_SCHEDULER_AUTH: InternalClusterAuthentication = Field(

services/autoscaling/tests/unit/test_utils_rabbitmq.py

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
ProgressRabbitMessageNode,
1919
ProgressType,
2020
)
21-
from pydantic import parse_obj_as
21+
from pydantic import TypeAdapter
2222
from pytest_mock.plugin import MockerFixture
2323
from servicelib.rabbitmq import BIND_TO_ALL_TOPICS, RabbitMQClient
2424
from settings_library.rabbit import RabbitSettings
@@ -78,8 +78,7 @@ async def test_post_task_log_message(
7878
"running",
7979
)
8080
assert service_with_labels.Spec
81-
service_tasks = parse_obj_as(
82-
list[Task],
81+
service_tasks = TypeAdapter(list[Task]).validate_python(
8382
await async_docker_client.tasks.list(
8483
filters={"service": service_with_labels.Spec.Name}
8584
),
@@ -103,7 +102,7 @@ async def test_post_task_log_message(
103102
messages=[f"[cluster] {log_message}"],
104103
log_level=0,
105104
)
106-
.json()
105+
.model_dump_json()
107106
.encode()
108107
)
109108
print("... message received")
@@ -125,8 +124,7 @@ async def test_post_task_log_message_does_not_raise_if_service_has_no_labels(
125124
):
126125
service_without_labels = await create_service(task_template, {}, "running")
127126
assert service_without_labels.Spec
128-
service_tasks = parse_obj_as(
129-
list[Task],
127+
service_tasks = TypeAdapter(list[Task]).validate_python(
130128
await async_docker_client.tasks.list(
131129
filters={"service": service_without_labels.Spec.Name}
132130
),
@@ -170,8 +168,7 @@ async def test_post_task_progress_message(
170168
"running",
171169
)
172170
assert service_with_labels.Spec
173-
service_tasks = parse_obj_as(
174-
list[Task],
171+
service_tasks = TypeAdapter(list[Task]).validate_python(
175172
await async_docker_client.tasks.list(
176173
filters={"service": service_with_labels.Spec.Name}
177174
),
@@ -195,7 +192,7 @@ async def test_post_task_progress_message(
195192
progress_type=ProgressType.CLUSTER_UP_SCALING,
196193
report=ProgressReport(actual_value=progress_value, total=1),
197194
)
198-
.json()
195+
.model_dump_json()
199196
.encode()
200197
)
201198
print("... message received")
@@ -217,8 +214,7 @@ async def test_post_task_progress_does_not_raise_if_service_has_no_labels(
217214
):
218215
service_without_labels = await create_service(task_template, {}, "running")
219216
assert service_without_labels.Spec
220-
service_tasks = parse_obj_as(
221-
list[Task],
217+
service_tasks = TypeAdapter(list[Task]).validate_python(
222218
await async_docker_client.tasks.list(
223219
filters={"service": service_without_labels.Spec.Name}
224220
),

0 commit comments

Comments
 (0)