@pcrespov review: good catch

sanderegg · sanderegg · commit 1aa81fb82cef · 2025-04-09T22:10:36.000+02:00
diff --git a/services/autoscaling/src/simcore_service_autoscaling/modules/auto_scaling_core.py b/services/autoscaling/src/simcore_service_autoscaling/modules/auto_scaling_core.py
@@ -475,7 +475,7 @@ async def _start_warm_buffer_instances(
         )
         # NOTE: first start the instance and then set the tags in case the instance cannot start (e.g. InsufficientInstanceCapacity)
         await get_ec2_client(app).set_instances_tags(
-            instances_to_start,
+            started_instances,
             tags=get_activated_buffer_ec2_tags(app, auto_scaling_mode),
         )
     started_instance_ids = [i.id for i in started_instances]

Original file line number	Diff line number	Diff line change
`@@ -475,7 +475,7 @@ async def _start_warm_buffer_instances(`
`475`	`475`	`)`
`476`	`476`	`# NOTE: first start the instance and then set the tags in case the instance cannot start (e.g. InsufficientInstanceCapacity)`
`477`	`477`	`await get_ec2_client(app).set_instances_tags(`
`478`		`- instances_to_start,`
	`478`	`+ started_instances,`
`479`	`479`	`tags=get_activated_buffer_ec2_tags(app, auto_scaling_mode),`
`480`	`480`	`)`
`481`	`481`	`started_instance_ids = [i.id for i in started_instances]`