Skip to content

Commit 1b0d899

Browse files
committed
some initial tests
1 parent 81958f3 commit 1b0d899

File tree

1 file changed

+14
-7
lines changed

1 file changed

+14
-7
lines changed

services/dask-sidecar/tests/unit/test_utils_dask.py

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -40,25 +40,32 @@
4040
def test_publish_event(
4141
dask_client: distributed.Client, job_id: str, task_owner: TaskOwner
4242
):
43-
dask_pub = distributed.Pub("some_topic", client=dask_client)
44-
dask_sub = distributed.Sub("some_topic", client=dask_client)
4543
event_to_publish = TaskProgressEvent(
4644
job_id=job_id,
4745
msg="the log",
4846
progress=1,
4947
task_owner=task_owner,
5048
)
51-
publish_event(dask_pub=dask_pub, event=event_to_publish)
49+
dask_client.log_event("some_topic", event_to_publish.model_dump_json())
50+
# publish_event(dask_pub=dask_pub, event=event_to_publish)
5251

5352
# NOTE: this tests runs a sync dask client,
5453
# and the CI seems to have sometimes difficulties having this run in a reasonable time
5554
# hence the long time out
56-
message = dask_sub.get(timeout=DASK_TESTING_TIMEOUT_S)
57-
assert message is not None
58-
assert isinstance(message, str)
59-
received_task_log_event = TaskProgressEvent.model_validate_json(message)
55+
events = dask_client.get_events("some_topic")
56+
assert events is not None
57+
assert isinstance(events, tuple)
58+
assert len(events) == 1
59+
assert isinstance(events[0], tuple)
60+
received_task_log_event = TaskProgressEvent.model_validate_json(events[0][1])
6061
assert received_task_log_event == event_to_publish
6162

63+
# message = dask_sub.get(timeout=DASK_TESTING_TIMEOUT_S)
64+
# assert message is not None
65+
# assert isinstance(message, str)
66+
# received_task_log_event = TaskProgressEvent.model_validate_json(message)
67+
# assert received_task_log_event == event_to_publish
68+
6269

6370
async def test_publish_event_async(
6471
async_dask_client: distributed.Client, job_id: str, task_owner: TaskOwner

0 commit comments

Comments
 (0)