Skip to content

Commit 1d3fcd6

Browse files
committed
models-library is not included
1 parent 2009b1d commit 1d3fcd6

File tree

3 files changed

+10
-12
lines changed

3 files changed

+10
-12
lines changed

packages/postgres-database/tests/conftest.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
from aiopg.sa.engine import Engine
2020
from aiopg.sa.result import ResultProxy, RowProxy
2121
from faker import Faker
22-
from models_library.products import ProductName
2322
from pytest_simcore.helpers import postgres_tools
2423
from pytest_simcore.helpers.faker_factories import (
2524
random_group,
@@ -328,10 +327,10 @@ async def _creator(project_uuid: uuid.UUID) -> ProjectNode:
328327
@pytest.fixture
329328
async def create_fake_product(
330329
asyncpg_engine: AsyncEngine,
331-
) -> AsyncIterator[Callable[[ProductName], Awaitable[Row]]]:
330+
) -> AsyncIterator[Callable[[str], Awaitable[Row]]]:
332331
created_product_names = set()
333332

334-
async def _creator(product_name: ProductName) -> Row:
333+
async def _creator(product_name: str) -> Row:
335334
async with asyncpg_engine.begin() as connection:
336335
result = await connection.execute(
337336
sa.insert(products)

packages/postgres-database/tests/test_utils_groups_extra_properties.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
import sqlalchemy
1212
from aiopg.sa.result import RowProxy
1313
from faker import Faker
14-
from models_library.products import ProductName
1514
from simcore_postgres_database.models.groups import GroupType, groups, user_to_groups
1615
from simcore_postgres_database.models.groups_extra_properties import (
1716
groups_extra_properties,
@@ -86,7 +85,7 @@ async def test_get(
8685
connection: aiopg.sa.connection.SAConnection,
8786
registered_user: RowProxy,
8887
product_name: str,
89-
create_fake_product: Callable[[ProductName], Awaitable[Row]],
88+
create_fake_product: Callable[[str], Awaitable[Row]],
9089
create_fake_group_extra_properties: Callable[..., Awaitable[GroupExtraProperties]],
9190
):
9291
with pytest.raises(GroupExtraPropertiesNotFoundError):
@@ -108,7 +107,7 @@ async def test_get_v2(
108107
asyncpg_engine: AsyncEngine,
109108
registered_user: RowProxy,
110109
product_name: str,
111-
create_fake_product: Callable[[ProductName], Awaitable[Row]],
110+
create_fake_product: Callable[[str], Awaitable[Row]],
112111
create_fake_group_extra_properties: Callable[..., Awaitable[GroupExtraProperties]],
113112
):
114113
with pytest.raises(GroupExtraPropertiesNotFoundError):
@@ -159,7 +158,7 @@ async def test_get_aggregated_properties_for_user_returns_properties_in_expected
159158
connection: aiopg.sa.connection.SAConnection,
160159
product_name: str,
161160
registered_user: RowProxy,
162-
create_fake_product: Callable[[ProductName], Awaitable[Row]],
161+
create_fake_product: Callable[[str], Awaitable[Row]],
163162
create_fake_group: Callable[..., Awaitable[RowProxy]],
164163
create_fake_group_extra_properties: Callable[..., Awaitable[GroupExtraProperties]],
165164
everyone_group_id: int,
@@ -229,7 +228,7 @@ async def test_get_aggregated_properties_for_user_returns_properties_in_expected
229228
connection: aiopg.sa.connection.SAConnection,
230229
product_name: str,
231230
registered_user: RowProxy,
232-
create_fake_product: Callable[[ProductName], Awaitable[Row]],
231+
create_fake_product: Callable[[str], Awaitable[Row]],
233232
create_fake_group: Callable[..., Awaitable[RowProxy]],
234233
create_fake_group_extra_properties: Callable[..., Awaitable[GroupExtraProperties]],
235234
everyone_group_id: int,
@@ -276,7 +275,7 @@ async def test_get_aggregated_properties_for_user_returns_property_values_as_tru
276275
connection: aiopg.sa.connection.SAConnection,
277276
product_name: str,
278277
registered_user: RowProxy,
279-
create_fake_product: Callable[[ProductName], Awaitable[Row]],
278+
create_fake_product: Callable[[str], Awaitable[Row]],
280279
create_fake_group: Callable[..., Awaitable[RowProxy]],
281280
create_fake_group_extra_properties: Callable[..., Awaitable[GroupExtraProperties]],
282281
everyone_group_id: int,
@@ -387,7 +386,7 @@ async def test_get_aggregated_properties_for_user_returns_property_values_as_tru
387386
connection: aiopg.sa.connection.SAConnection,
388387
product_name: str,
389388
registered_user: RowProxy,
390-
create_fake_product: Callable[[ProductName], Awaitable[Row]],
389+
create_fake_product: Callable[[str], Awaitable[Row]],
391390
create_fake_group: Callable[..., Awaitable[RowProxy]],
392391
create_fake_group_extra_properties: Callable[..., Awaitable[GroupExtraProperties]],
393392
everyone_group_id: int,

packages/postgres-database/tests/test_utils_user_preferences.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ def preference_two() -> str:
2929

3030
@pytest.fixture
3131
async def product_name(
32-
create_fake_product: Callable[[ProductName], Awaitable[Row]],
32+
create_fake_product: Callable[[str], Awaitable[Row]],
3333
) -> str:
3434
product = await create_fake_product("fake-product")
3535
return product[0]
@@ -204,7 +204,7 @@ async def test__same_preference_name_product_name__different_users(
204204

205205
async def test__same_user_preference_name__different_product_name(
206206
connection: AsyncConnection,
207-
create_fake_product: Callable[[ProductName], Awaitable[Row]],
207+
create_fake_product: Callable[[str], Awaitable[Row]],
208208
preference_repo: type[BasePreferencesRepo],
209209
preference_one: str,
210210
faker: Faker,

0 commit comments

Comments
 (0)