Skip to content

Commit 1d66815

Browse files
author
Andrei Neagu
committed
added missing error handling
1 parent 1bb8bcf commit 1d66815

File tree

1 file changed

+3
-2
lines changed
  • services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core

1 file changed

+3
-2
lines changed

services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core/_events_utils.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
from models_library.users import UserID
2222
from servicelib.fastapi.http_client_thin import BaseHttpClientError
2323
from servicelib.logging_utils import log_context
24+
from servicelib.long_running_tasks.errors import GenericClientError
2425
from servicelib.long_running_tasks.models import ProgressCallback, TaskProgress
2526
from servicelib.rabbitmq import RabbitMQClient
2627
from servicelib.rabbitmq._client_rpc import RabbitMQRPCClient
@@ -134,7 +135,7 @@ async def service_remove_containers(
134135
await sidecars_client.stop_service(
135136
scheduler_data.endpoint, progress_callback=progress_callback
136137
)
137-
except BaseHttpClientError as e:
138+
except (BaseHttpClientError, GenericClientError) as e:
138139
_logger.info(
139140
(
140141
"Could not remove service containers for %s. "
@@ -369,7 +370,7 @@ async def attempt_pod_removal_and_data_saving(
369370
scheduler_data.dynamic_sidecar.were_state_and_outputs_saved = True
370371

371372
_logger.info("dynamic-sidecar saved: state and output ports")
372-
except BaseHttpClientError as e:
373+
except (BaseHttpClientError, GenericClientError) as e:
373374
_logger.error( # noqa: TRY400
374375
(
375376
"Could not contact dynamic-sidecar to save service "

0 commit comments

Comments
 (0)