🐛Autoscaling: Ensure a safe memory margin is removed to account for OPS services when starting dynamic services (#6038)

sanderegg · matusdrobuliak66 · commit 1e6eae6dec15 · 2024-07-11T11:54:06.000+02:00
diff --git a/services/web/server/src/simcore_service_webserver/projects/projects_api.py b/services/web/server/src/simcore_service_webserver/projects/projects_api.py
@@ -387,6 +387,7 @@ def _by_type_name(ec2: EC2InstanceTypeGet) -> bool:
         new_ram_value = int(
             selected_ec2_instance_type.ram
             - _MACHINE_TOTAL_RAM_SAFE_MARGIN_RATIO * selected_ec2_instance_type.ram
+            - _SIDECARS_OPS_SAFE_RAM_MARGIN
         )
         if DEFAULT_SINGLE_SERVICE_NAME not in node_resources:
             # NOTE: we go for the largest sub-service and scale it up/down

Original file line number	Diff line number	Diff line change
`@@ -387,6 +387,7 @@ def _by_type_name(ec2: EC2InstanceTypeGet) -> bool:`
`387`	`387`	`new_ram_value = int(`
`388`	`388`	`selected_ec2_instance_type.ram`
`389`	`389`	`- _MACHINE_TOTAL_RAM_SAFE_MARGIN_RATIO * selected_ec2_instance_type.ram`
	`390`	`+ - _SIDECARS_OPS_SAFE_RAM_MARGIN`
`390`	`391`	`)`
`391`	`392`	`if DEFAULT_SINGLE_SERVICE_NAME not in node_resources:`
`392`	`393`	`# NOTE: we go for the largest sub-service and scale it up/down`