Skip to content

Commit 1e97ead

Browse files
continue fixing
1 parent c5dd024 commit 1e97ead

File tree

4 files changed

+19
-19
lines changed

4 files changed

+19
-19
lines changed

services/web/server/src/simcore_service_webserver/director_v2/settings.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
from aiohttp import ClientSession, ClientTimeout, web
88
from models_library.basic_types import VersionTag
9-
from pydantic import Field, PositiveInt
9+
from pydantic import AliasChoices, Field, PositiveInt
1010
from servicelib.aiohttp.application_keys import APP_CLIENT_SESSION_KEY
1111
from settings_library.base import BaseCustomSettings
1212
from settings_library.basic_types import PortInt
@@ -36,9 +36,9 @@ def base_url(self) -> URL:
3636
DIRECTOR_V2_RESTART_DYNAMIC_SERVICE_TIMEOUT: PositiveInt = Field(
3737
1 * _MINUTE,
3838
description="timeout of containers restart",
39-
envs=[
39+
validation_alias=AliasChoices(
4040
"DIRECTOR_V2_RESTART_DYNAMIC_SERVICE_TIMEOUT",
41-
],
41+
),
4242
)
4343

4444
DIRECTOR_V2_STORAGE_SERVICE_UPLOAD_DOWNLOAD_TIMEOUT: PositiveInt = Field(
@@ -49,9 +49,9 @@ def base_url(self) -> URL:
4949
"such payloads it is required to have long timeouts which "
5050
"allow the service to finish the operation."
5151
),
52-
envs=[
52+
validation_alias=AliasChoices(
5353
"DIRECTOR_V2_DYNAMIC_SERVICE_DATA_UPLOAD_DOWNLOAD_TIMEOUT",
54-
],
54+
),
5555
)
5656

5757
def get_service_retrieve_timeout(self) -> ClientTimeout:

services/web/server/src/simcore_service_webserver/meta_modeling/_results.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,5 +110,5 @@ def extract_project_results(workbench: dict[str, Any]) -> ExtractedResults:
110110
values = node["outputs"]
111111
results[noid], labels[noid] = values, label
112112

113-
res = ExtractedResults(progress=progress, labels=labels, values=results) # type: ignore[arg-type]
113+
res = ExtractedResults(progress=progress, labels=labels, values=results)
114114
return res

services/web/server/src/simcore_service_webserver/studies_dispatcher/_projects.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
from models_library.projects_nodes_io import DownloadLink, NodeID, PortLink
1919
from models_library.projects_ui import StudyUI
2020
from models_library.services import ServiceKey, ServiceVersion
21-
from pydantic import AnyUrl, HttpUrl, parse_obj_as
21+
from pydantic import AnyUrl, HttpUrl, TypeAdapter
2222
from servicelib.logging_utils import log_decorator
2323

2424
from ..projects.db import ProjectDBAPI
@@ -32,10 +32,10 @@
3232
_logger = logging.getLogger(__name__)
3333

3434

35-
_FILE_PICKER_KEY: ServiceKey = parse_obj_as(
36-
ServiceKey, "simcore/services/frontend/file-picker"
35+
_FILE_PICKER_KEY: ServiceKey = TypeAdapter(ServiceKey).validate_python(
36+
"simcore/services/frontend/file-picker"
3737
)
38-
_FILE_PICKER_VERSION: ServiceVersion = parse_obj_as(ServiceVersion, "1.0.0")
38+
_FILE_PICKER_VERSION: ServiceVersion = TypeAdapter(ServiceVersion).validate_python("1.0.0")
3939

4040

4141
def _generate_nodeids(project_id: ProjectID) -> tuple[NodeID, NodeID]:
@@ -55,12 +55,12 @@ def _create_file_picker(download_link: str, output_label: str | None):
5555
# also to name the file in case it is downloaded
5656

5757
data = {}
58-
data["downloadLink"] = url = parse_obj_as(AnyUrl, download_link)
58+
data["downloadLink"] = url = TypeAdapter(AnyUrl).validate_python(download_link)
5959
if output_label:
6060
data["label"] = Path(output_label).name
6161
elif url.path:
6262
data["label"] = Path(url.path).name
63-
output = DownloadLink.parse_obj(data)
63+
output = DownloadLink.model_validate(data)
6464

6565
output_id = "outFile"
6666
node = Node(
@@ -69,7 +69,7 @@ def _create_file_picker(download_link: str, output_label: str | None):
6969
label="File Picker",
7070
inputs={},
7171
inputNodes=[],
72-
outputs={output_id: output}, # type: ignore[dict-item]
72+
outputs={output_id: output},
7373
progress=0,
7474
)
7575
return node, output_id
@@ -94,12 +94,12 @@ def _create_project(
9494
uuid=project_id,
9595
name=name,
9696
description=description,
97-
thumbnail=thumbnail, # type: ignore[arg-type]
97+
thumbnail=thumbnail,
9898
prjOwner=owner.email,
9999
accessRights={owner.primary_gid: access_rights}, # type: ignore[dict-item]
100100
creationDate=DateTimeStr(now_str()),
101101
lastChangeDate=DateTimeStr(now_str()),
102-
workbench=workbench, # type: ignore[arg-type]
102+
workbench=workbench,
103103
ui=StudyUI(workbench=workbench_ui), # type: ignore[arg-type]
104104
)
105105

@@ -153,7 +153,7 @@ def _create_project_with_filepicker_and_service(
153153
version=viewer_info.version,
154154
label=viewer_info.label,
155155
inputs={
156-
viewer_info.input_port_key: PortLink( # type: ignore[dict-item]
156+
viewer_info.input_port_key: PortLink(
157157
nodeUuid=file_picker_id,
158158
output=file_picker_output_id,
159159
)

services/web/server/src/simcore_service_webserver/studies_dispatcher/settings.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
from datetime import timedelta
2-
from typing import Any, ClassVar
32

43
from aiohttp import web
54
from common_library.pydantic_validators import validate_numeric_string_as_timedelta
6-
from pydantic import TypeAdapter, field_validator, ConfigDict, ByteSize, HttpUrl
5+
from pydantic import TypeAdapter, field_validator, ByteSize, HttpUrl
76
from pydantic.fields import Field
7+
from pydantic_settings import SettingsConfigDict
88
from servicelib.aiohttp.application_keys import APP_SETTINGS_KEY
99
from settings_library.base import BaseCustomSettings
1010

@@ -54,7 +54,7 @@ def is_login_required(self):
5454
_validate_studies_guest_account_lifetime = validate_numeric_string_as_timedelta(
5555
"STUDIES_GUEST_ACCOUNT_LIFETIME"
5656
)
57-
model_config = ConfigDict(
57+
model_config = SettingsConfigDict(
5858
json_schema_extra={
5959
"example": {
6060
"STUDIES_GUEST_ACCOUNT_LIFETIME": "2 1:10:00", # 2 days 1h and 10 mins

0 commit comments

Comments
 (0)