Skip to content

Commit 1ec6ab7

Browse files
authored
✨ Sends approval and rejection emails from the PO center (🚨) (#8094)
1 parent 83c06b5 commit 1ec6ab7

File tree

13 files changed

+1404
-1046
lines changed

13 files changed

+1404
-1046
lines changed

.github/copilot-instructions.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ This document provides guidelines and best practices for using GitHub Copilot in
1212

1313
## 🛠️Coding Instructions for Python in This Repository
1414

15-
Follow these rules strictly when generating Python code:
15+
Follow these rules **strictly** when generating Python code:
1616

1717
### 1. Python Version
1818

@@ -43,7 +43,7 @@ Ensure compatibility with the following library versions:
4343
* Use `f-string` formatting for all string interpolation except for logging message strings.
4444
* Use **relative imports** within the same package/module.
4545
* Place **all imports at the top** of the file.
46-
* Add comments **only when the code is not self-explanatory**.
46+
* Document functions when the code is not self-explanatory or if asked explicitly.
4747

4848

4949
### 6. **JSON Serialization**

services/web/server/src/simcore_service_webserver/login_accounts/_service.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
from ..email.utils import send_email_from_template
1818
from ..products import products_web
1919
from ..products.models import Product
20-
from ..users import _users_service
20+
from ..users import _accounts_service
2121
from ..users.schemas import PreRegisteredUserGet
2222

2323
_logger = logging.getLogger(__name__)
@@ -136,6 +136,6 @@ async def create_pre_registration(
136136
app: web.Application, *, profile: PreRegisteredUserGet, product_name: ProductName
137137
):
138138

139-
await _users_service.pre_register_user(
139+
await _accounts_service.pre_register_user(
140140
app, profile=profile, creator_user_id=None, product_name=product_name
141141
)

0 commit comments

Comments
 (0)