efs improvements

Author: matusdrobuliak66

services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/docker_service_specs/sidecar.py

@@ -404,7 +404,6 @@ async def get_dynamic_sidecar_spec(  # pylint:disable=too-many-arguments# noqa:
     app_settings: AppSettings,
     *,
     has_quota_support: bool,
-    allow_internet_access: bool,
     hardware_info: HardwareInfo | None,
     metrics_collection_allowed: bool,
     user_extra_properties: UserExtraProperties,
@@ -506,7 +505,7 @@ async def get_dynamic_sidecar_spec(  # pylint:disable=too-many-arguments# noqa:
                     compose_namespace,
                     scheduler_data,
                     app_settings,
-                    allow_internet_access=allow_internet_access,
+                    allow_internet_access=user_extra_properties.is_internet_enabled,
                     metrics_collection_allowed=metrics_collection_allowed,
                     telemetry_enabled=user_extra_properties.is_telemetry_enabled,
                 ),

services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core/_event_create_sidecars.py

@@ -235,7 +235,6 @@ async def action(cls, app: FastAPI, scheduler_data: SchedulerData) -> None:
             app_settings=app.state.settings,
             hardware_info=scheduler_data.hardware_info,
             has_quota_support=dynamic_services_scheduler_settings.DYNAMIC_SIDECAR_ENABLE_VOLUME_LIMITS,
-            allow_internet_access=allow_internet_access,
             metrics_collection_allowed=metrics_collection_allowed,
             user_extra_properties=user_extra_properties,
             rpc_client=rpc_client,

services/director-v2/tests/unit/with_dbs/test_modules_dynamic_sidecar_docker_service_specs.py

@@ -454,11 +454,10 @@ async def test_get_dynamic_proxy_spec(
             app_settings=minimal_app.state.settings,
             hardware_info=hardware_info,
             has_quota_support=False,
-            allow_internet_access=False,
             metrics_collection_allowed=True,
             user_extra_properties=UserExtraProperties(
-                is_internet_enabled=True,
-                is_telemetry_enabled=False,
+                is_internet_enabled=False,
+                is_telemetry_enabled=True,
                 is_efs_enabled=False,
             ),
             rpc_client=Mock(),
@@ -553,11 +552,10 @@ async def test_merge_dynamic_sidecar_specs_with_user_specific_specs(
         app_settings=minimal_app.state.settings,
         hardware_info=hardware_info,
         has_quota_support=False,
-        allow_internet_access=False,
         metrics_collection_allowed=True,
         user_extra_properties=UserExtraProperties(
-            is_internet_enabled=True,
-            is_telemetry_enabled=False,
+            is_internet_enabled=False,
+            is_telemetry_enabled=True,
             is_efs_enabled=False,
         ),
         rpc_client=Mock(),