increase coverage

Author: pcrespov

services/web/server/src/simcore_service_webserver/login/cli.py

@@ -16,12 +16,12 @@ def invitations(
     user_id: int = 1,
     num_codes: int = 15,
     code_length: int = 30,
-):
+) -> None:
     """Generates a list of invitation links for registration"""
 
     invitation = ConfirmedInvitationData(issuer=issuer_email, trial_account_days=trial_days)  # type: ignore[call-arg] # guest field is deprecated
 
-    codes = [generate_password(code_length) for _ in range(num_codes)]
+    codes: list[str] = [generate_password(code_length) for _ in range(num_codes)]
 
     typer.secho(
         "{:-^100}".format("invitations.md"),
@@ -48,19 +48,19 @@ def invitations(
 
     utcnow = datetime.now(tz=UTC)
     today: datetime = utcnow.today()
-    print("code,user_id,action,data,created_at", file=sys.stdout)
+    print("code,user_id,action,data,created_at", file=sys.stdout)  # noqa: T201
     for n, code in enumerate(codes, start=1):
-        print(f'{code},{user_id},INVITATION,"{{', file=sys.stdout)
-        print(
+        print(f'{code},{user_id},INVITATION,"{{', file=sys.stdout)  # noqa: T201
+        print(  # noqa: T201
             f'""guest"": ""invitation-{today.year:04d}{today.month:02d}{today.day:02d}-{n}"" ,',
             file=sys.stdout,
         )
-        print(f'""issuer"" : ""{invitation.issuer}"" ,', file=sys.stdout)
-        print(
+        print(f'""issuer"" : ""{invitation.issuer}"" ,', file=sys.stdout)  # noqa: T201
+        print(  # noqa: T201
             f'""trial_account_days"" : ""{invitation.trial_account_days}""',
             file=sys.stdout,
         )
-        print('}",%s' % utcnow.isoformat(sep=" "), file=sys.stdout)
+        print('}}",{}'.format(utcnow.isoformat(sep=" ")), file=sys.stdout)  # noqa: T201
 
     typer.secho(
         "-" * 100,

services/web/server/tests/unit/with_dbs/03/login/test_login_cli.py

@@ -0,0 +1,46 @@
+from io import StringIO
+
+import simcore_service_webserver.login.cli
+from pytest_mock import MockerFixture
+from simcore_service_webserver.login.cli import invitations
+from yarl import URL
+
+
+def test_invitations(mocker: MockerFixture):
+    base_url = "http://example.com"
+    issuer_email = "[email protected]"
+    trial_days = 7
+    user_id = 42
+    num_codes = 3
+    code_length = 10
+
+    # Spy on generate_password to track generated codes
+    spy_generate_password = mocker.spy(
+        simcore_service_webserver.login.cli, "generate_password"
+    )
+
+    # Mock sys.stdout to capture printed output
+    mock_stdout = StringIO()
+    mocker.patch("sys.stdout", new=mock_stdout)
+
+    invitations(
+        base_url=base_url,
+        issuer_email=issuer_email,
+        trial_days=trial_days,
+        user_id=user_id,
+        num_codes=num_codes,
+        code_length=code_length,
+    )
+
+    output = mock_stdout.getvalue()
+
+    # Assert that the correct number of passwords were generated
+    assert spy_generate_password.call_count == num_codes
+
+    # Collect generated codes
+    generated_codes = spy_generate_password.spy_return_list
+
+    # Assert that the invitation links are correctly generated
+    for i, code in enumerate(generated_codes, start=1):
+        expected_url = URL(base_url).with_fragment(f"/registration/?invitation={code}")
+        assert f"{i:2d}. {expected_url}" in output