Skip to content

Commit 2244e95

Browse files
committed
fixes response model in open-project
1 parent 3f43cf9 commit 2244e95

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

services/web/server/src/simcore_service_webserver/projects/_states_handlers.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import logging
99

1010
from aiohttp import web
11+
from models_library.api_schemas_webserver.projects import ProjectGet
1112
from models_library.projects_state import ProjectState
1213
from pydantic import BaseModel
1314
from servicelib.aiohttp import status
@@ -169,7 +170,7 @@ async def open_project(request: web.Request) -> web.Response:
169170
)
170171
await projects_api.notify_project_state_update(request.app, project)
171172

172-
return envelope_json_response(project)
173+
return envelope_json_response(ProjectGet.from_domain_model(project))
173174

174175
except DirectorServiceError as exc:
175176
# there was an issue while accessing the director-v2/director-v0

services/web/server/tests/unit/with_dbs/02/test_projects_states_handlers.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1368,7 +1368,7 @@ async def test_open_shared_project_at_same_time(
13681368
client: TestClient,
13691369
client_on_running_server_factory: Callable,
13701370
logged_user: dict,
1371-
shared_project: dict,
1371+
shared_project: ProjectDict,
13721372
socketio_client_factory: Callable,
13731373
client_session_id_factory: Callable,
13741374
user_role: UserRole,
@@ -1444,7 +1444,7 @@ async def test_open_shared_project_at_same_time(
14441444
elif data:
14451445
project_status = ProjectState(**data.pop("state"))
14461446
data.pop("folderId")
1447-
assert data == shared_project
1447+
assert data == {k: shared_project[k] for k in data}
14481448
assert project_status.locked.value
14491449
assert project_status.locked.owner
14501450
assert project_status.locked.owner.first_name in [

services/web/server/tests/unit/with_dbs/03/version_control/test_version_control_handlers.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
import pytest
1313
from aiohttp.test_utils import TestClient
1414
from models_library.api_schemas_webserver.projects import ProjectGet
15-
from models_library.projects import Project, ProjectID
15+
from models_library.projects import ProjectID
1616
from models_library.rest_pagination import Page
1717
from models_library.users import UserID
1818
from pydantic.main import BaseModel
@@ -180,7 +180,7 @@ async def test_workflow(
180180
# get working copy
181181
resp = await client.get(f"/{VX}/projects/{project_uuid}")
182182
data, _ = await assert_status(resp, status.HTTP_200_OK)
183-
project_wc = Project.model_validate(data)
183+
project_wc = ProjectGet.model_validate(data)
184184
assert project_wc.uuid == UUID(project_uuid)
185185
assert project_wc != project
186186

0 commit comments

Comments
 (0)