Skip to content

Commit 22596c0

Browse files
committed
simcore-sdk migrated
1 parent 96de578 commit 22596c0

File tree

3 files changed

+11
-7
lines changed

3 files changed

+11
-7
lines changed

services/api-server/src/simcore_service_api_server/services_http/solver_job_outputs.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import logging
22
from typing import Any, TypeAlias
33

4-
import aiopg
54
from models_library.projects import ProjectID, ProjectIDStr
65
from models_library.projects_nodes_io import BaseFileLink, NodeID, NodeIDStr
76
from pydantic import StrictBool, StrictFloat, StrictInt, TypeAdapter
87
from simcore_sdk import node_ports_v2
98
from simcore_sdk.node_ports_v2 import DBManager, Nodeports
9+
from sqlalchemy.ext.asyncio import AsyncEngine
1010

1111
from ..exceptions.backend_errors import SolverOutputNotFoundError
1212

@@ -19,7 +19,7 @@
1919

2020

2121
async def get_solver_output_results(
22-
user_id: int, project_uuid: ProjectID, node_uuid: NodeID, db_engine: aiopg.sa.Engine
22+
user_id: int, project_uuid: ProjectID, node_uuid: NodeID, db_engine: AsyncEngine
2323
) -> dict[str, ResultsTypes]:
2424
"""
2525
Wraps calls via node_ports to retrieve project's output

services/director-v2/src/simcore_service_director_v2/utils/dask.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@
3838
)
3939
from simcore_sdk.node_ports_v2 import FileLinkType, Port, links, port_utils
4040
from simcore_sdk.node_ports_v2.links import ItemValue as _NPItemValue
41+
from sqlalchemy.ext.asyncio import AsyncEngine
4142

4243
from ..constants import UNDEFINED_DOCKER_LABEL
4344
from ..core.errors import (
@@ -106,7 +107,10 @@ def parse_dask_job_id(
106107

107108

108109
async def create_node_ports(
109-
db_engine: Engine, user_id: UserID, project_id: ProjectID, node_id: NodeID
110+
db_engine: AsyncEngine,
111+
user_id: UserID,
112+
project_id: ProjectID,
113+
node_id: NodeID,
110114
) -> node_ports_v2.Nodeports:
111115
"""
112116
This function create a nodeports object by fetching the node state from the database
@@ -633,7 +637,7 @@ def check_if_cluster_is_able_to_run_pipeline(
633637

634638

635639
async def wrap_client_async_routine(
636-
client_coroutine: Coroutine[Any, Any, Any] | Any | None
640+
client_coroutine: Coroutine[Any, Any, Any] | Any | None,
637641
) -> Any:
638642
"""Dask async behavior does not go well with Pylance as it returns
639643
a union of types. this wrapper makes both mypy and pylance happy"""

services/director-v2/tests/integration/02/test_dynamic_sidecar_nodeports_integration.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
import aioboto3
1818
import aiodocker
19-
import aiopg.sa
2019
import httpx
2120
import pytest
2221
import sqlalchemy as sa
@@ -79,6 +78,7 @@
7978
from simcore_service_director_v2.core.settings import AppSettings
8079
from simcore_service_director_v2.modules import storage as dv2_modules_storage
8180
from sqlalchemy.dialects.postgresql import insert as pg_insert
81+
from sqlalchemy.ext.asyncio import AsyncEngine
8282
from tenacity import TryAgain
8383
from tenacity.asyncio import AsyncRetrying
8484
from tenacity.retry import retry_if_exception_type
@@ -293,8 +293,8 @@ def workbench_dynamic_services(
293293

294294

295295
@pytest.fixture
296-
async def db_manager(aiopg_engine: aiopg.sa.engine.Engine) -> DBManager:
297-
return DBManager(aiopg_engine)
296+
async def db_manager(sqlalchemy_async_engine: AsyncEngine) -> DBManager:
297+
return DBManager(sqlalchemy_async_engine)
298298

299299

300300
def _is_docker_r_clone_plugin_installed() -> bool:

0 commit comments

Comments
 (0)