Skip to content

Commit 24f8abd

Browse files
author
Andrei Neagu
committed
refactor settings
1 parent 8387d84 commit 24f8abd

File tree

1 file changed

+6
-13
lines changed
  • services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/core

1 file changed

+6
-13
lines changed

services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/core/settings.py

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22
from datetime import timedelta
33
from functools import lru_cache
44
from pathlib import Path
5-
from typing import Annotated, cast
5+
from typing import cast
66

77
from common_library.pydantic_validators import validate_numeric_string_as_timedelta
8-
from models_library.basic_types import BootModeEnum, PortInt
8+
from models_library.basic_types import PortInt
99
from models_library.callbacks_mapping import CallbacksMapping
1010
from models_library.products import ProductName
1111
from models_library.projects import ProjectID
@@ -21,8 +21,8 @@
2121
field_validator,
2222
)
2323
from servicelib.logging_utils_filtering import LoggerName, MessageSubstring
24+
from settings_library.application import BaseApplicationSettings
2425
from settings_library.aws_s3_cli import AwsS3CliSettings
25-
from settings_library.base import BaseCustomSettings
2626
from settings_library.docker_registry import RegistrySettings
2727
from settings_library.node_ports import StorageAuthSettings
2828
from settings_library.postgres import PostgresSettings
@@ -35,7 +35,7 @@
3535
from settings_library.utils_logging import MixinLoggingSettings
3636

3737

38-
class ResourceTrackingSettings(BaseCustomSettings):
38+
class ResourceTrackingSettings(BaseApplicationSettings):
3939
RESOURCE_TRACKING_HEARTBEAT_INTERVAL: timedelta = Field(
4040
default=DEFAULT_RESOURCE_USAGE_HEARTBEAT_INTERVAL,
4141
description="each time the status of the service is propagated",
@@ -46,20 +46,13 @@ class ResourceTrackingSettings(BaseCustomSettings):
4646
)
4747

4848

49-
class SystemMonitorSettings(BaseCustomSettings):
49+
class SystemMonitorSettings(BaseApplicationSettings):
5050
DY_SIDECAR_SYSTEM_MONITOR_TELEMETRY_ENABLE: bool = Field(
5151
default=False, description="enabled/disabled disk usage monitoring"
5252
)
5353

5454

55-
class ApplicationSettings(BaseCustomSettings, MixinLoggingSettings):
56-
SC_BOOT_MODE: Annotated[
57-
BootModeEnum,
58-
Field(
59-
...,
60-
description="boot mode helps determine if in development mode or normal operation",
61-
),
62-
]
55+
class ApplicationSettings(BaseApplicationSettings, MixinLoggingSettings):
6356

6457
DYNAMIC_SIDECAR_DY_VOLUMES_MOUNT_DIR: Path = Field(
6558
...,

0 commit comments

Comments
 (0)