added exception for share state

Author: sanderegg

services/web/server/src/simcore_service_webserver/projects/_projects_service.py

@@ -9,6 +9,7 @@
 
 import asyncio
 import collections
+import contextlib
 import datetime
 import logging
 from collections import defaultdict
@@ -162,6 +163,7 @@
     InvalidEC2TypeInResourcesSpecsError,
     InvalidKeysInResourcesSpecsError,
     NodeNotFoundError,
+    NodeShareStateCannotBeComputedError,
     ProjectInvalidRightsError,
     ProjectLockError,
     ProjectNodeConnectionsMissingError,
@@ -1382,10 +1384,10 @@ async def _get_node_share_state(
                 status=NodeShareStatus.OPENED,
             )
         if isinstance(service, NodeGetUnknown):
-            # service state is unknown
-            # we should raise an exception here
-            msg = "Node state is unknown"
-            raise RuntimeError(msg)
+            # service state is unknown, raise
+            raise NodeShareStateCannotBeComputedError(
+                project_uuid=project_uuid, node_uuid=node_id
+            )
         return NodeShareState(locked=False)
 
     # if the service is computational and no pipeline is running it is not locked
@@ -1879,19 +1881,23 @@ async def add_project_states_for_user(
         assert isinstance(node_uuid, str)  # nosec
         assert isinstance(node, dict)  # nosec
 
-        node_lock_state = await _get_node_share_state(
-            app,
-            user_id=user_id,
-            project_uuid=project["uuid"],
-            node_id=NodeID(node_uuid),
-        )
+        node_lock_state = None
+        with contextlib.suppress(NodeShareStateCannotBeComputedError):
+            node_lock_state = await _get_node_share_state(
+                app,
+                user_id=user_id,
+                project_uuid=project["uuid"],
+                node_id=NodeID(node_uuid),
+            )
         if NodeID(node_uuid) in computational_node_states:
             node_state = computational_node_states[NodeID(node_uuid)].model_copy(
                 update={"lock_state": node_lock_state}
             )
         else:
             # if the node is not in the computational state, we create a new one
-            service_is_running = node_lock_state.status is NodeShareStatus.OPENED
+            service_is_running = node_lock_state and (
+                node_lock_state.status is NodeShareStatus.OPENED
+            )
             node_state = NodeState(
                 current_status=(
                     RunningState.STARTED

services/web/server/src/simcore_service_webserver/projects/exceptions.py

@@ -4,6 +4,7 @@
 from typing import Any
 
 from models_library.projects import ProjectID
+from models_library.projects_nodes_io import NodeID
 from models_library.users import UserID
 from servicelib.redis import ProjectLockError
 
@@ -106,7 +107,9 @@ class ProjectRunningConflictError(ProjectTrashError):
 
 
 class ProjectNotTrashedError(ProjectTrashError):
-    msg_template = "Cannot delete project {project_uuid} since it was not trashed first: {details}"
+    msg_template = (
+        "Cannot delete project {project_uuid} since it was not trashed first: {details}"
+    )
 
 
 class NodeNotFoundError(BaseProjectError):
@@ -118,6 +121,17 @@ def __init__(self, *, project_uuid: str, node_uuid: str, **ctx):
         self.project_uuid = project_uuid
 
 
+class NodeShareStateCannotBeComputedError(BaseProjectError):
+    msg_template = (
+        "Node '{node_uuid}' share state cannot be computed in project '{project_uuid}'"
+    )
+
+    def __init__(self, *, project_uuid: ProjectID | None, node_uuid: NodeID, **ctx):
+        super().__init__(**ctx)
+        self.node_uuid = node_uuid
+        self.project_uuid = project_uuid
+
+
 class ParentNodeNotFoundError(BaseProjectError):
     msg_template = "Parent node '{node_uuid}' not found"