Skip to content

Commit 27082c9

Browse files
committed
use correct fileid
1 parent 7e5a251 commit 27082c9

File tree

2 files changed

+23
-9
lines changed
  • services/api-server/src/simcore_service_api_server

2 files changed

+23
-9
lines changed

services/api-server/src/simcore_service_api_server/api/routes/files.py

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -108,10 +108,13 @@ async def _get_file(
108108

109109

110110
async def _create_domain_file(
111-
webserver_api: AuthSession, client_file: UserFile | UserFileToProgramJob
111+
*,
112+
webserver_api: AuthSession,
113+
file_id: UUID | None,
114+
client_file: UserFile | UserFileToProgramJob,
112115
) -> DomainFile:
113116
if isinstance(client_file, UserFile):
114-
file = client_file.to_domain_model()
117+
file = client_file.to_domain_model(file_id=file_id)
115118
elif isinstance(client_file, UserFileToProgramJob):
116119
project = await webserver_api.get_project(project_id=client_file.job_id)
117120
if len(project.workbench) > 1:
@@ -276,7 +279,9 @@ async def get_upload_links(
276279
):
277280
"""Get upload links for uploading a file to storage"""
278281
assert request # nosec
279-
file_meta = await _create_domain_file(webserver_api, client_file)
282+
file_meta = await _create_domain_file(
283+
webserver_api=webserver_api, file_id=None, client_file=client_file
284+
)
280285
_, upload_links = await get_upload_links_from_s3(
281286
user_id=user_id,
282287
store_name=None,
@@ -391,7 +396,9 @@ async def abort_multipart_upload(
391396
assert request # nosec
392397
assert user_id # nosec
393398

394-
file = await _create_domain_file(webserver_api, client_file)
399+
file = await _create_domain_file(
400+
webserver_api=webserver_api, file_id=file_id, client_file=client_file
401+
)
395402
abort_link: URL = await storage_client.create_abort_upload_link(
396403
file=file, query={"user_id": str(user_id)}
397404
)
@@ -418,7 +425,9 @@ async def complete_multipart_upload(
418425
assert file_id # nosec
419426
assert request # nosec
420427
assert user_id # nosec
421-
file = await _create_domain_file(webserver_api, client_file)
428+
file = await _create_domain_file(
429+
webserver_api=webserver_api, file_id=file_id, client_file=client_file
430+
)
422431
complete_link: URL = await storage_client.create_complete_upload_link(
423432
file=file, query={"user_id": str(user_id)}
424433
)

services/api-server/src/simcore_service_api_server/models/schemas/files.py

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,17 @@ class UserFile(ApiServerInputSchema):
3030

3131
def to_domain_model(
3232
self,
33+
file_id: UUID | None = None,
3334
) -> DomainFile:
3435
return DomainFile(
35-
id=DomainFile.create_id(
36-
self.filesize,
37-
self.filename,
38-
datetime.datetime.now(datetime.UTC).isoformat(),
36+
id=(
37+
file_id
38+
if file_id
39+
else DomainFile.create_id(
40+
self.filesize,
41+
self.filename,
42+
datetime.datetime.now(datetime.UTC).isoformat(),
43+
)
3944
),
4045
filename=self.filename,
4146
checksum=self.sha256_checksum,

0 commit comments

Comments
 (0)