✨ Refactor: Replace json.loads with json_loads for consistency across modules

Author: pcrespov

packages/service-library/src/servicelib/aiohttp/rest_middlewares.py

@@ -3,7 +3,6 @@
 SEE  https://gist.github.com/amitripshtos/854da3f4217e3441e8fceea85b0cbd91
 """
 
-import json
 import logging
 from collections.abc import Awaitable, Callable
 from typing import Any, Union
@@ -12,7 +11,7 @@
 from aiohttp.web_request import Request
 from aiohttp.web_response import StreamResponse
 from common_library.error_codes import create_error_code
-from common_library.json_serialization import json_dumps
+from common_library.json_serialization import json_dumps, json_loads
 from models_library.rest_error import ErrorGet, ErrorItemType, LogMessageType
 
 from ..logging_errors import create_troubleshotting_log_kwargs
@@ -107,7 +106,7 @@ async def _middleware_handler(request: web.Request, handler: Handler):
             err.content_type = MIMETYPE_APPLICATION_JSON
             if err.text:
                 try:
-                    payload = json.loads(err.text)
+                    payload = json_loads(err.text)
                     if not is_enveloped_from_map(payload):
                         payload = wrap_as_envelope(data=payload)
                         err.text = json_dumps(payload)

packages/service-library/src/servicelib/rest_responses.py

@@ -2,6 +2,8 @@
 from collections.abc import Mapping
 from typing import Any
 
+from common_library.json_serialization import json_loads
+
 _ENVELOPE_KEYS = ("data", "error")
 
 
@@ -11,7 +13,7 @@ def is_enveloped_from_map(payload: Mapping) -> bool:
 
 def is_enveloped_from_text(text: str) -> bool:
     try:
-        payload = json.loads(text)
+        payload = json_loads(text)
     except json.decoder.JSONDecodeError:
         return False
     return is_enveloped_from_map(payload)

packages/simcore-sdk/src/simcore_sdk/node_ports_common/dbmanager.py

@@ -9,6 +9,7 @@
 import tenacity
 from aiopg.sa.engine import Engine
 from aiopg.sa.result import RowProxy
+from common_library.json_serialization import json_loads
 from models_library.projects import ProjectID
 from models_library.users import UserID
 from servicelib.common_aiopg_utils import DataSourceName, create_pg_engine
@@ -113,7 +114,7 @@ async def write_ports_configuration(
         )
         log.debug(message)
 
-        node_configuration = json.loads(json_configuration)
+        node_configuration = json_loads(json_configuration)
         async with DBContextManager(
             self._db_engine
         ) as engine, engine.acquire() as connection:

packages/simcore-sdk/src/simcore_sdk/node_ports_common/file_io_utils.py

@@ -1,5 +1,4 @@
 import asyncio
-import json
 import logging
 from collections.abc import AsyncGenerator, Coroutine
 from contextlib import AsyncExitStack
@@ -17,6 +16,7 @@
     ClientSession,
     RequestInfo,
 )
+from common_library.json_serialization import json_loads
 from models_library.api_schemas_storage.storage_schemas import (
     ETag,
     FileUploadSchema,
@@ -143,8 +143,7 @@ class ProgressData:
 
 @runtime_checkable
 class LogRedirectCB(Protocol):
-    async def __call__(self, log: str) -> None:
-        ...
+    async def __call__(self, log: str) -> None: ...
 
 
 async def _file_chunk_writer(
@@ -276,7 +275,7 @@ async def _session_put(
         assert response.status == status.HTTP_200_OK  # nosec
         assert response.headers  # nosec
         assert "Etag" in response.headers  # nosec
-        etag: str = json.loads(response.headers["Etag"])
+        etag: str = json_loads(response.headers["Etag"])
         return etag
 
 

packages/simcore-sdk/src/simcore_sdk/node_ports_v2/serialization_v2.py

@@ -1,11 +1,10 @@
 import functools
-import json
 import logging
 from pprint import pformat
 from typing import Any
 
 import pydantic
-from common_library.json_serialization import json_dumps
+from common_library.json_serialization import json_dumps, json_loads
 from models_library.projects_nodes_io import NodeID
 from models_library.utils.nodes import compute_node_hash
 from packaging import version
@@ -50,7 +49,7 @@ async def load(
     port_config_str: str = await db_manager.get_ports_configuration_from_node_uuid(
         project_id, node_uuid
     )
-    port_cfg = json.loads(port_config_str)
+    port_cfg = json_loads(port_config_str)
 
     log.debug(f"{port_cfg=}")  # pylint: disable=logging-fstring-interpolation
     if any(k not in port_cfg for k in NODE_REQUIRED_KEYS):