[skip ci] more refactoring

Author: odeimaiz

services/static-webserver/client/source/class/osparc/dashboard/CardBase.js

@@ -491,13 +491,13 @@ qx.Class.define("osparc.dashboard.CardBase", {
           uuid = resourceData.uuid ? resourceData.uuid : null;
           owner = resourceData.prjOwner ? resourceData.prjOwner : "";
           workbench = resourceData.workbench ? resourceData.workbench : {};
-          icon = osparc.study.Utils.guessIcon(resourceData);
+          // icon = osparc.study.Utils.guessIcon(resourceData);
           break;
         case "template":
           uuid = resourceData.uuid ? resourceData.uuid : null;
           owner = resourceData.prjOwner ? resourceData.prjOwner : "";
           workbench = resourceData.workbench ? resourceData.workbench : {};
-          icon = osparc.study.Utils.guessIcon(resourceData);
+          // icon = osparc.study.Utils.guessIcon(resourceData);
           break;
         case "service":
           uuid = resourceData.key ? resourceData.key : null;
@@ -539,6 +539,8 @@ qx.Class.define("osparc.dashboard.CardBase", {
             resourceData["services"] = services;
             this.setServices(services);
           });
+
+        // icon = osparc.study.Utils.guessIcon(resourceData);
       }
     },
 

services/static-webserver/client/source/class/osparc/dashboard/NewPlusMenu.js

@@ -343,7 +343,7 @@ qx.Class.define("osparc.dashboard.NewPlusMenu", {
             });
             for (let i=0; i<newStudyData["myMostUsed"]; i++) {
               const latestMetadata = servicesList[i];
-              if (latestMetadata["hits"] > 0) {
+              if (latestMetadata && latestMetadata["hits"] > 0) {
                 const menuButton = new qx.ui.menu.Button().set({
                   label: latestMetadata["name"],
                   font: "text-16",

services/static-webserver/client/source/class/osparc/study/Utils.js

@@ -331,29 +331,35 @@ qx.Class.define("osparc.study.Utils", {
     },
 
     guessIcon: function(studyData) {
-      if (osparc.product.Utils.isProduct("tis") || osparc.product.Utils.isProduct("tiplite")) {
-        return this.__guessTIPIcon(studyData);
-      }
-      return this.__guessIcon(studyData);
+      return new Promise(resolve => {
+        if (osparc.product.Utils.isProduct("tis") || osparc.product.Utils.isProduct("tiplite")) {
+          resolve(this.__guessTIPIcon(studyData));
+        } else {
+          resolve(this.__guessIcon(studyData));
+        }
+      });
     },
 
     __guessIcon: function(studyData) {
-      // the was to guess the TI type is to check the boot mode of the ti-postpro in the pipeline
-      const wbServices = this.self().getNonFrontendNodes(studyData);
-      if (wbServices.length === 1) {
-        const wbService = wbServices[0];
-        const allServices = osparc.store.Services.servicesCached;
-        if (wbService.key in allServices && wbService.version in allServices[wbService.key]) {
-          const serviceMetadata = allServices[wbService.key][wbService.version];
-          if (serviceMetadata["icon"]) {
-            return serviceMetadata["icon"];
-          }
+      const defaultIcon = osparc.dashboard.CardBase.PRODUCT_ICON;
+      return new Promise(resolve => {
+        // the was to guess the TI type is to check the boot mode of the ti-postpro in the pipeline
+        const wbServices = this.self().getNonFrontendNodes(studyData);
+        if (wbServices.length === 1) {
+          const wbService = wbServices[0];
+          osparc.store.Services.getService(wbService.key, wbService.version)
+            .then(serviceMetadata => {
+              if (serviceMetadata["icon"]) {
+                resolve(serviceMetadata["icon"]);
+              }
+              resolve(defaultIcon);
+            });
+        } else if (wbServices.length > 1) {
+          resolve("osparc/icons/diagram.png");
+        } else {
+          resolve(defaultIcon);
         }
-      }
-      if (wbServices.length > 1) {
-        return "osparc/icons/diagram.png";
-      }
-      return osparc.dashboard.CardBase.PRODUCT_ICON;
+      });
     },
 
     __guessTIPIcon: function(studyData) {