review sugestions

Author: Andrei Neagu

packages/service-library/src/servicelib/long_running_tasks/_redis_store.py

@@ -23,14 +23,14 @@ def _load_from_redis_hash(data: dict[str, str]) -> dict[str, Any]:
     return {k: json_loads(v) for k, v in data.items()}
 
 
-def to_redis_namespace(namespace: LRTNamespace) -> str:
-    return namespace.upper()
+def to_redis_namespace(lrt_namespace: LRTNamespace) -> str:
+    return lrt_namespace.upper()
 
 
 class RedisStore:
-    def __init__(self, redis_settings: RedisSettings, namespace: LRTNamespace):
+    def __init__(self, redis_settings: RedisSettings, lrt_namespace: LRTNamespace):
         self.redis_settings = redis_settings
-        self.redis_namespace: str = to_redis_namespace(namespace)
+        self.redis_namespace = to_redis_namespace(lrt_namespace)
 
         self._client: RedisClientSDK | None = None
 

packages/service-library/tests/long_running_tasks/test_long_running_tasks__redis_store.py

@@ -36,7 +36,7 @@ async def store(
         [RedisDatabase], AbstractAsyncContextManager[RedisClientSDK]
     ],
 ) -> AsyncIterable[RedisStore]:
-    store = RedisStore(redis_settings=use_in_memory_redis, namespace="test")
+    store = RedisStore(redis_settings=use_in_memory_redis, lrt_namespace="test")
 
     await store.setup()
     yield store
@@ -78,7 +78,7 @@ async def redis_stores(
     ],
 ) -> AsyncIterable[list[RedisStore]]:
     stores: list[RedisStore] = [
-        RedisStore(redis_settings=use_in_memory_redis, namespace=f"test-{i}")
+        RedisStore(redis_settings=use_in_memory_redis, lrt_namespace=f"test-{i}")
         for i in range(5)
     ]
     for store in stores:

packages/service-library/tests/long_running_tasks/test_long_running_tasks_client_long_running_manager.py

@@ -25,7 +25,7 @@ def task_data() -> TaskData:
 
 @pytest.fixture
 def lrt_namespace(faker: Faker) -> LRTNamespace:
-    return f"test-namespace:{faker.uuid4()}"
+    return TypeAdapter(LRTNamespace).validate_python(f"test-namespace:{faker.uuid4()}")
 
 
 @pytest.fixture
@@ -36,7 +36,7 @@ async def store(
     ],
     lrt_namespace: LRTNamespace,
 ) -> AsyncIterable[RedisStore]:
-    store = RedisStore(redis_settings=use_in_memory_redis, namespace=lrt_namespace)
+    store = RedisStore(redis_settings=use_in_memory_redis, lrt_namespace=lrt_namespace)
 
     await store.setup()
     yield store