Skip to content

Commit 2933b0e

Browse files
committed
@sanderegg change requests
1 parent 98b9a1a commit 2933b0e

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

.env-devel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ POSTGRES_HOST=postgres
194194
POSTGRES_PASSWORD=adminadmin
195195
POSTGRES_PORT=5432
196196
POSTGRES_USER=scu
197-
POSTGRES_MINSIZE=2
197+
POSTGRES_MINSIZE=2 # see https://github.com/ITISFoundation/osparc-simcore/pull/8199
198198
POSTGRES_MAXSIZE=50
199199
POSTGRES_READONLY_PASSWORD=readonly
200200
POSTGRES_READONLY_USER=postgres_readonly

packages/service-library/src/servicelib/db_asyncpg_utils.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,9 @@ async def create_async_engine_and_database_ready(
3030
raise_if_migration_not_ready,
3131
)
3232

33-
server_settings = {"jit": "off"}
33+
server_settings = {
34+
"jit": "off"
35+
} # see https://docs.sqlalchemy.org/en/20/dialects/postgresql.html#disabling-the-postgresql-jit-to-improve-enum-datatype-handling
3436
if settings.POSTGRES_CLIENT_NAME:
3537
assert isinstance(settings.POSTGRES_CLIENT_NAME, str) # nosec
3638
server_settings.update(

packages/settings-library/src/settings_library/postgres.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,10 @@ class PostgresSettings(BaseCustomSettings):
3131

3232
# pool connection limits
3333
POSTGRES_MINSIZE: Annotated[
34-
int, Field(description="Minimum number of connections in the pool", ge=1)
35-
] = 2
34+
int, Field(description="Minimum number of connections in the pool", ge=2)
35+
] = 2 # see https://github.com/ITISFoundation/osparc-simcore/pull/8199
3636
POSTGRES_MAXSIZE: Annotated[
37-
int, Field(description="Maximum number of connections in the pool", ge=1)
37+
int, Field(description="Maximum number of connections in the pool", ge=2)
3838
] = 50
3939

4040
POSTGRES_CLIENT_NAME: Annotated[

0 commit comments

Comments
 (0)