still to be fixed

Author: sanderegg

services/storage/tests/conftest.py

@@ -65,9 +65,6 @@
 from simcore_service_storage.datcore_dsm import DatCoreDataManager
 from simcore_service_storage.dsm import get_dsm_provider
 from simcore_service_storage.models import FileMetaData, FileMetaDataAtDB, S3BucketName
-from simcore_service_storage.modules.long_running_tasks import (
-    get_completed_upload_tasks,
-)
 from simcore_service_storage.modules.s3 import get_s3_client
 from simcore_service_storage.simcore_s3_dsm import SimcoreS3DataManager
 from sqlalchemy import literal_column
@@ -503,8 +500,8 @@ async def _directory_creator(
         assert file_upload_complete_response
         state_url = URL(f"{file_upload_complete_response.links.state}").relative()
 
-        # check that it finished updating
-        get_completed_upload_tasks(initialized_app).clear()
+        # check that it finished updating TODO: this works via celery now
+        # get_completed_upload_tasks(initialized_app).clear()
         # now check for the completion
         async for attempt in AsyncRetrying(
             reraise=True,

services/storage/tests/unit/test_handlers_files.py

@@ -55,9 +55,6 @@
 from servicelib.aiohttp import status
 from simcore_service_storage.constants import S3_UNDEFINED_OR_EXTERNAL_MULTIPART_ID
 from simcore_service_storage.models import FileDownloadResponse, S3BucketName, UploadID
-from simcore_service_storage.modules.long_running_tasks import (
-    get_completed_upload_tasks,
-)
 from simcore_service_storage.simcore_s3_dsm import SimcoreS3DataManager
 from sqlalchemy.ext.asyncio import AsyncEngine
 from tenacity.asyncio import AsyncRetrying
@@ -682,8 +679,8 @@ async def test_upload_real_file_with_emulated_storage_restart_after_completion_w
     assert file_upload_complete_response
     state_url = URL(f"{file_upload_complete_response.links.state}").relative()
 
-    # here we do not check now for the state completion. instead we simulate a restart where the tasks disappear
-    get_completed_upload_tasks(initialized_app).clear()
+    # # here we do not check now for the state completion. instead we simulate a restart where the tasks disappear TODO: fix
+    # get_completed_upload_tasks(initialized_app).clear()
     # now check for the completion
     completion_etag = None
     async for attempt in AsyncRetrying(