refactor

Author: Andrei Neagu

packages/service-library/src/servicelib/fastapi/prometheus_instrumentation.py

@@ -22,12 +22,12 @@ def initialize_prometheus_instrumentation(app: FastAPI) -> None:
     app.state.prometheus_instrumentator.instrument(app)
 
 
-async def _startup(app: FastAPI) -> None:
+def _startup(app: FastAPI) -> None:
     assert isinstance(app.state.prometheus_instrumentator, Instrumentator)  # nosec
     app.state.prometheus_instrumentator.expose(app, include_in_schema=False)
 
 
-async def _shutdown(app: FastAPI) -> None:
+def _shutdown(app: FastAPI) -> None:
     assert isinstance(app.state.prometheus_registry, CollectorRegistry)  # nosec
     registry = app.state.prometheus_registry
     for collector in list(registry._collector_to_names.keys()):  # noqa: SLF001
@@ -42,15 +42,21 @@ def get_prometheus_instrumentator(app: FastAPI) -> Instrumentator:
 def setup_prometheus_instrumentation(app: FastAPI) -> Instrumentator:
     initialize_prometheus_instrumentation(app)
 
-    app.add_event_handler("startup", _startup)
-    app.add_event_handler("shutdown", _shutdown)
+    async def _on_startup() -> None:
+        _startup(app)
+
+    def _on_shutdown() -> None:
+        _shutdown(app)
+
+    app.add_event_handler("startup", _on_startup)
+    app.add_event_handler("shutdown", _on_shutdown)
 
     return get_prometheus_instrumentator(app)
 
 
 async def lifespan_prometheus_instrumentation(app: FastAPI) -> AsyncIterator[State]:
     # NOTE: requires ``initialize_prometheus_instrumentation`` to be called before the
     # lifespan of the applicaiton runs, usually rigth after the ``FastAPI`` instance is created
-    await _startup(app)
+    _startup(app)
     yield {}
-    await _shutdown(app)
+    _shutdown(app)