Skip to content

Commit 29fb222

Browse files
authored
Merge branch 'master' into pr-osparc-move-service-extras-to-catalog2
2 parents 9f3bcd7 + a0f438e commit 29fb222

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

services/invitations/src/simcore_service_invitations/services/invitations.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,7 @@ def _build_link(
6464
r = URL("/registration").include_query_params(invitation=code_url_safe)
6565

6666
# Adds query to fragment
67-
base_url = f"{base_url}/"
68-
url = URL(base_url).replace(fragment=f"{r}")
67+
url = URL(f"{base_url.rstrip('/')}/").replace(fragment=f"{r}")
6968
return TypeAdapter(HttpUrl).validate_python(f"{url}")
7069

7170

services/invitations/tests/unit/api/test_api_invitations.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,10 @@ def test_create_invitation(
4141
assert invitation.guest == invitation_input.guest
4242
assert invitation.trial_account_days == invitation_input.trial_account_days
4343

44+
# checks issue with `//` reported in https://github.com/ITISFoundation/osparc-simcore/issues/7055
45+
assert invitation.invitation_url
46+
assert invitation.invitation_url.path == "/"
47+
4448
assert invitation.product
4549
if invitation_input.product:
4650
assert invitation.product == invitation_input.product

0 commit comments

Comments
 (0)