Skip to content

Commit 2a1a3e0

Browse files
committed
minor
1 parent 075d70d commit 2a1a3e0

File tree

1 file changed

+1
-43
lines changed

1 file changed

+1
-43
lines changed

packages/aws-library/tests/test_ec2_client.py

Lines changed: 1 addition & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -579,49 +579,7 @@ async def test_remove_instance_tags_not_existing_raises(
579579
)
580580

581581

582-
async def test_launch_instances_multi_subnet_fallback(
583-
simcore_ec2_api: SimcoreEC2API,
584-
ec2_client: EC2Client,
585-
fake_ec2_instance_type: EC2InstanceType,
586-
faker: Faker,
587-
aws_subnet_id: str,
588-
aws_security_group_id: str,
589-
aws_ami_id: str,
590-
):
591-
"""Test that launch_instances works with multiple subnet IDs."""
592-
await _assert_no_instances_in_ec2(ec2_client)
593-
594-
# Create a config with multiple subnet IDs, including the valid one
595-
ec2_instance_config = EC2InstanceConfig(
596-
type=fake_ec2_instance_type,
597-
tags=faker.pydict(allowed_types=(str,)),
598-
startup_script=faker.pystr(),
599-
ami_id=aws_ami_id,
600-
key_name=faker.pystr(),
601-
security_group_ids=[aws_security_group_id],
602-
subnet_ids=[aws_subnet_id, "subnet-backup1", "subnet-backup2"],
603-
iam_instance_profile="",
604-
)
605-
606-
# This should succeed using the first (valid) subnet
607-
await simcore_ec2_api.launch_instances(
608-
ec2_instance_config,
609-
min_number_of_instances=1,
610-
number_of_instances=1,
611-
)
612-
613-
# Verify that the instance was created
614-
await _assert_instances_in_ec2(
615-
ec2_client,
616-
expected_num_reservations=1,
617-
expected_num_instances=1,
618-
expected_instance_type=ec2_instance_config.type,
619-
expected_tags=ec2_instance_config.tags,
620-
expected_state="running",
621-
)
622-
623-
624-
async def test_launch_instances_multi_subnet_fallback_with_invalid_subnets(
582+
async def test_launch_instances_with_multi_subnets(
625583
simcore_ec2_api: SimcoreEC2API,
626584
ec2_client: EC2Client,
627585
fake_ec2_instance_type: EC2InstanceType,

0 commit comments

Comments
 (0)