refactor: rename parameters in get_service_ports method for clarity and update corresponding tests

Author: pcrespov

packages/models-library/src/models_library/api_schemas_catalog/services_ports.py

@@ -29,17 +29,29 @@ class ServicePortGet(BaseModel):
 
     model_config = ConfigDict(
         json_schema_extra={
-            "example": {
-                "key": "input_1",
-                "kind": "input",
-                "content_schema": {
-                    "title": "Sleep interval",
-                    "type": "integer",
-                    "x_unit": "second",
-                    "minimum": 0,
-                    "maximum": 5,
+            "examples": [
+                {
+                    "key": "input_1",
+                    "kind": "input",
+                    "content_schema": {
+                        "title": "Sleep interval",
+                        "type": "integer",
+                        "x_unit": "second",
+                        "minimum": 0,
+                        "maximum": 5,
+                    },
                 },
-            }
+                {
+                    "key": "output_1",
+                    "kind": "output",
+                    "content_media_type": "text/plain",
+                    "content_schema": {
+                        "type": "string",
+                        "title": "File containing one random integer",
+                        "description": "Integer is generated in range [1-9]",
+                    },
+                },
+            ]
         }
     )
 

services/api-server/src/simcore_service_api_server/services_rpc/catalog.py

@@ -127,8 +127,8 @@ async def get_service_ports(
         *,
         product_name: ProductName,
         user_id: UserID,
-        service_key: ServiceKey,
-        service_version: ServiceVersion,
+        name: ServiceKey,
+        version: ServiceVersion,
     ) -> list[ServicePortGet]:
         """Gets service ports (inputs and outputs) for a specific service version
 
@@ -141,6 +141,6 @@ async def get_service_ports(
             self._client,
             product_name=product_name,
             user_id=user_id,
-            service_key=service_key,
-            service_version=service_version,
+            service_key=name,
+            service_version=version,
         )

services/api-server/tests/unit/test_services_catalog.py

@@ -80,8 +80,8 @@ async def test_catalog_service_read_solvers(
     ports = await catalog_service.get_service_ports(
         product_name=product_name,
         user_id=user_id,
-        service_key=selected_solver.id,
-        service_version=oldest_release.version,
+        name=selected_solver.id,
+        version=oldest_release.version,
     )
 
     # Verify ports are returned and contain both inputs and outputs