Skip to content

Commit 2dd48d4

Browse files
committed
cleanup
1 parent 5507295 commit 2dd48d4

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

services/web/server/src/simcore_service_webserver/groups/_groups_api.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,10 @@ async def update_user_in_group(
178178

179179

180180
async def delete_user_in_group(
181-
app: web.Application, user_id: UserID, gid: GroupID, the_user_id_in_group: int
181+
app: web.Application,
182+
user_id: UserID,
183+
gid: GroupID,
184+
the_user_id_in_group: int,
182185
) -> None:
183186
return await _groups_db.delete_user_in_group(
184187
app, user_id=user_id, gid=gid, the_user_id_in_group=the_user_id_in_group

services/web/server/tests/unit/with_dbs/01/test_groups.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
import pytest
1313
from aiohttp.test_utils import TestClient
1414
from faker import Faker
15+
from models_library.groups import AccessRightsDict
1516
from pytest_simcore.helpers.assert_checks import assert_status
1617
from pytest_simcore.helpers.webserver_login import LoggedUser, NewUser, UserInfoDict
1718
from pytest_simcore.helpers.webserver_parametrizations import (
@@ -25,7 +26,6 @@
2526
from simcore_service_webserver._meta import API_VTAG
2627
from simcore_service_webserver.application_settings import setup_settings
2728
from simcore_service_webserver.db.plugin import setup_db
28-
from simcore_service_webserver.groups._common.types import AccessRightsDict
2929
from simcore_service_webserver.groups._groups_db import (
3030
_DEFAULT_GROUP_OWNER_ACCESS_RIGHTS,
3131
_DEFAULT_GROUP_READ_ACCESS_RIGHTS,
@@ -62,9 +62,7 @@ def client(
6262
# fake config
6363
app = create_safe_application(cfg)
6464

65-
settings = setup_settings(app)
66-
print(settings.model_dump_json(indent=1))
67-
65+
setup_settings(app)
6866
setup_db(app)
6967
setup_session(app)
7068
setup_security(app)
@@ -92,9 +90,9 @@ def _assert__group_user(
9290
actual_user: dict,
9391
):
9492
assert "first_name" in actual_user
95-
assert actual_user["first_name"] == expected_user["first_name"]
93+
assert actual_user["first_name"] == expected_user.get("first_name")
9694
assert "last_name" in actual_user
97-
assert actual_user["last_name"] == expected_user["last_name"]
95+
assert actual_user["last_name"] == expected_user.get("last_name")
9896
assert "login" in actual_user
9997
assert actual_user["login"] == expected_user["email"]
10098
assert "gravatar_id" in actual_user

0 commit comments

Comments
 (0)